-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3950] Make service catalogue more consistent with Signicat template #63
Conversation
0c48e8b
to
2acd1ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 96.01% 96.10% +0.08%
==========================================
Files 72 73 +1
Lines 3216 3260 +44
==========================================
+ Hits 3088 3133 +45
+ Misses 128 127 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have a lot of experience in xml-xsd so I don't find something weird.
I am not sure about the last bullet in the task "They don't have the signature node => The XSD has no value for the minOccurs
and the default is 1
(https://www.w3.org/TR/xmlschema-0/#OccurrenceConstraints). So I think we need to leave this field in?"
I guess you are right.
Discussion with Joeri:
|
This is a bit of a test, because we don't know if they will work
2acd1ed
to
b35e6e3
Compare
Fixes open-formulieren/open-forms#3950 (first checkbox)
Context
Signicat, one of the Identity Providers for eHerkenning, said that the service catalogue that we generated was 'invalid'. The Signicat template can be found here: https://developer.signicat.com/broker/eherkenning-broker/eherkenning-service-catalogue.html#introduction
The noticed differences are mentioned in the ticket.
The service catalogue gets validated against this XSD: https://afsprakenstelsel.etoegang.nl/display/as/Service+catalog (under
XML schema Service Catalog
)