♻️ Use cryptography primivites for x509 certificate processing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the (implicitly installed) PyOpenSSL dependency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 72 72
Lines 3215 3216 +1
=======================================
+ Hits 3087 3088 +1
Misses 128 128 ☔ View full report in Codecov by Sentry. |
SilviaAmAm
reviewed
Feb 22, 2024
Comment on lines
+278
to
+279
| # grab the actual base64 data describding the certificate, but without the | ||
| # BEGIN/END CERTIFICATE headers and footers and stripped of line breaks. |
There was a problem hiding this comment.
Is this new behaviour or is it the same as before?
There was a problem hiding this comment.
Same as before, I had to step through the code with a debugger to figure out what the original code was even doing 😬
SilviaAmAm
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the (implicitly installed) PyOpenSSL dependency.