[cstor#128] Remove tgt from zfs repository #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kryl <jan.kryl@cloudbyte.com>
jkryl
pushed a commit
that referenced
this pull request
Jun 26, 2018
* [GIT#31] zil_replay during open_dataset, flush API, fix for issue in uzfs_close_dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things: removing tgt and changing guid tests and code. Now we compare reported guids with real guids as reported by zpool and zfs commands. I have found out that there are two types of guids for dataset: fsid_guid and guid. fsid guid is guaranteed to be unique but can change. If during creation or import of a dataset it is found out that there is another dataset with the same guid the guid of created/imported file system is changed. The other guid is more suitable for our purpose, since we require that it never changes. Since the zvol guid is used in conjunction with spa guid the danger of collision is very very unlikely.
And the last change is separation of gtest routines which are generally useful to a separate file which can be shared between gtest test suites.