rebase: feat: add more generalized Stats #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
modify driver interface to take a QueryResponse on
Query() func calls for future backwards compat
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
remove unused code
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
remove NamedStats
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
make value interface
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
make value interface{}
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
rename StatsEntry.Key to .Scope
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
reshape stats
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
pull out err from QueryResponse, rt nil
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
add driver specific opt
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
move StatsEntries to Responses
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
add labels, source struct
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
use Source in GetDescription
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
add target label
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
fix description string
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
acpana
commented
Mar 1, 2023
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.11.3 | |||
| controller-gen.kubebuilder.io/version: v0.10.0 | |||
There was a problem hiding this comment.
changes in this file are prolly from a bad rebase, please ignore
|
closing since base branch was merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a rebase of open-policy-agent#283 onto the multi engine work