Check MMDB_get_metadata_as_entry_data_list return value

maxmind · Jan 23, 2025 · b8f93b4 · b8f93b4
1 parent 2a3b007
commit b8f93b4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -7,6 +7,8 @@ History
 ++++++++++++++++++
 
 * The vendored ``libmaxminddb`` has been updated to 1.12.2.
+* The C extension now checks that the database metadata lookup was
+  successful.
 
 2.6.3 (2025-01-09)
 ++++++++++++++++++

diff --git a/extension/maxminddb.c b/extension/maxminddb.c
@@ -351,7 +351,14 @@ static PyObject *Reader_metadata(PyObject *self, PyObject *UNUSED(args)) {
     }
 
     MMDB_entry_data_list_s *entry_data_list;
-    MMDB_get_metadata_as_entry_data_list(mmdb_obj->mmdb, &entry_data_list);
+    int status =
+        MMDB_get_metadata_as_entry_data_list(mmdb_obj->mmdb, &entry_data_list);
+    if (status != MMDB_SUCCESS) {
+        PyErr_Format(MaxMindDB_error,
+                     "Error decoding metadata. %s",
+                     MMDB_strerror(status));
+        return NULL;
+    }
     MMDB_entry_data_list_s *original_entry_data_list = entry_data_list;
 
     PyObject *metadata_dict = from_entry_data_list(&entry_data_list);