onRemove(): only restore original position if set

[ulken]

If the marker is never bounced, the original position is never stored.

Trying to set the position to undefined throws an error.

This behavior is a consequence of #42.

[maximeh]

Indeed! Good catch, should've seen that at the review of the previous PR.

Wonder if there's any way to do good unit testing here, I don't the javascript world, any advice on some tool/framework that could be used?

[ulken]

My go-to testing library for unit testing JS is AVA. However, I think it could be a little tricky with the DOM and Leaflet's usage of globals etc. But should definitely be possible. Might have to use something like JSDOM to make it work.

Another possibility, which may be easier to get going with, is to do end-to-end testing with something like Cypress or Playwright.

[maximeh]

Cool; thanks for the links. AVA looks real nice. For a start, I think snapshot testing/comparison to make sure the marker ends up where it should in all scenarios would be a very good start, I'll make an issue, maybe one of theses days I'll have time for that :/.