New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types #41

Merged

maximeh merged 3 commits into maximeh:main from ulken:fix-complete_types

Sep 19, 2021

ulken commented Sep 15, 2021 •

edited

Loading

Simplify import
Add methods: bounce() and stopBounce()
Replace Function with () => void
Make all options optional
Add "types" to package.json, for types to automatically be picked up by TypeScript

Closes #40

Oskar Löfgren added 2 commits

September 15, 2021 23:48


          Fix types

bb2bb84

- Simplify import
- Add methods: `bounce()` and `stopBounce()`
- Replace `Function` with `() => void`


          Add "types" to package.json

dce4fb1

For types to automatically be picked up by TypeScript.

ulken mentioned this pull request

.bounce() is missing in TypeScript definition #40

Closed


          Formatting and make options optional

maximeh merged commit a1662ce into maximeh:main

Owner

maximeh commented Sep 19, 2021

LGTM; thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet