Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(cli)!: change cli exit code to 0 on success and print to stdout #12

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

kenibrewer
Copy link
Contributor

@kenibrewer kenibrewer commented Oct 21, 2024

Changes:

  • spinner now prints to stderr
  • cli now returns 0 on success
  • cli returns 1 on failure to find a quote

Closes #11

I've labeled this a !BREAKING CHANGE in case anyone relies on the old cli behavior (relevant xkcd).

!BREAKING CHANGE
- spinner now prints to stderr
- cli now returns 0 on success
- cli returns 1 on failure to find a quote

Closes maxhumber#11
@kenibrewer kenibrewer force-pushed the fix/quote-cli-return branch from 200458b to ca2e7d1 Compare October 21, 2024 19:15
@maxhumber maxhumber merged commit 2444711 into maxhumber:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have quote cli print to stdout instead of strderr and return exit code 0 on success
2 participants