Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xz support #7

Merged
merged 3 commits into from
Sep 8, 2016
Merged

Add xz support #7

merged 3 commits into from
Sep 8, 2016

Conversation

jonathanspw
Copy link

@jonathanspw jonathanspw commented Jul 28, 2016

Adds a -x flag with XZ support.

XZ with default args can produce files half the size of gz on average.

130M zabbix_cfg_127.0.0.1_20160728-1316_db-3.0.0.sql.gz
53M zabbix_cfg_127.0.0.1_20160728-1319_db-3.0.0.sql.xz

@jonathanspw
Copy link
Author

Any thoughts on this merge?

@maxhq
Copy link
Owner

maxhq commented Aug 3, 2016

Oh sorry, I forgot to answer after reviewing it. It's a very nice idea!
I just wanted to remove the redundant messages in lines 336/343 and 348/349 before merging.

@jonathanspw
Copy link
Author

Hmm good idea. I didn't really like that when I added it anyway. I'll see about getting that cleaned up tomorrow.

@maxhq maxhq merged commit 89d469f into maxhq:master Sep 8, 2016
@maxhq
Copy link
Owner

maxhq commented Sep 8, 2016

I now rewrote your implementation a bit and added another option for "no compression".
You will find the changes in the new release 0.8.2.
Thank you very much for your commitment to improve this script!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants