-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filterfalse to itertools #109
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 99.07% 99.08% +0.01%
==========================================
Files 20 20
Lines 2047 2075 +28
Branches 314 321 +7
==========================================
+ Hits 2028 2056 +28
Misses 11 11
Partials 8 8
☔ View full report in Codecov by Sentry. |
Thanks for the contribution and especially for spotting that this was missing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks overall good to go. Please take a look at the failed "Static Checks" and adjust the code accordingly.
Feel free to disregard the codecov failure. I'll leave it up to you whether you want to address the CodeQL report, I'm fine with both variants.
- Static Checks must succeed
- Consider to address the CodeQL report
Both should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go!
No description provided.