Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete itertools.chain interface #108

Merged
merged 13 commits into from
Apr 16, 2023
Merged

Conversation

maxfischer2781
Copy link
Owner

@maxfischer2781 maxfischer2781 commented Apr 12, 2023

This PR adjusts the itertools.chain class to provide similar functionality as before. Major changes include:

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 90.69% and project coverage change: -0.19 ⚠️

Comparison is base (d20a48b) 99.25% compared to head (ad8c89c) 99.07%.

❗ Current head ad8c89c differs from pull request most recent head 872c26d. Consider uploading reports for the commit 872c26d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   99.25%   99.07%   -0.19%     
==========================================
  Files          20       20              
  Lines        2017     2047      +30     
  Branches      308      314       +6     
==========================================
+ Hits         2002     2028      +26     
- Misses         10       11       +1     
- Partials        5        8       +3     
Impacted Files Coverage Δ
unittests/test_itertools.py 98.01% <88.46%> (-1.99%) ⬇️
asyncstdlib/itertools.py 98.62% <94.11%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxfischer2781 maxfischer2781 marked this pull request as ready for review April 14, 2023 16:01
@maxfischer2781 maxfischer2781 merged commit b966a95 into master Apr 16, 2023
@maxfischer2781 maxfischer2781 deleted the maintenance/chain-close branch January 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in behavior of chain() between 3.10.5 and 3.10.6.
1 participant