#11 Mark FIXME

maxbechtold · Feb 3, 2020 · 70ab894 · 70ab894
1 parent f02ed3c
commit 70ab894
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/maxbe/goldenmaster/approval/ApprovalIdResolver.java b/src/main/java/maxbe/goldenmaster/approval/ApprovalIdResolver.java
@@ -31,7 +31,8 @@ public String resolveRunIdFor(ExtensionContext context) {
     private String getRunIdSuffix(String displayName) {
         // Sadly, it's infeasible to provide the invocation index via the ExtensionContext as we get here
         // @BeforeEach test invocation. Thus, derive it from the display name.
-        // TODO MAX Perhaps ExtensionContext#getConfigurationParameter can provide the index?
+        // Perhaps ExtensionContext#getConfigurationParameter can provide the index?
+        // FIXME #11 Without multiple invocationContexts, this will not find a name[index] pattern and crash
         String idWithoutBraces = displayName.substring(1, displayName.length() - 1);
         int runId = Integer.valueOf(idWithoutBraces) - 1;
         return "[" + runId + "]";