Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asbplayer integration #72

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

killergerbah
Copy link

@killergerbah killergerbah commented Sep 9, 2023

  • Add integration for asbplayer that parses asbplayer subtitle DOM when asbplayer has the "pre-cache subtitle DOM" setting enabled.
  • Fix popups not displaying on top of fullscreen video sometimes. This is needed for e.g. Crunchyroll where the popup is hidden by fullscreen video if it's placed inside of document.body. A best-effort fix for Allow popup to be shown on top of most fullscreen videos #59 .
  • Allow parse requests for text greater than the max parse limit via batching. This enables subtitle files with lots of text to be parsed entirely.

@killergerbah killergerbah marked this pull request as draft September 9, 2023 23:47
@killergerbah killergerbah marked this pull request as ready for review September 10, 2023 16:07
@Oshibuki
Copy link

Oshibuki commented May 1, 2024

It looks like the author of this project has stopped working. Can you please publish a release file of your own?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants