Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/time indication after midnight #1512

Open
wants to merge 12 commits into
base: release-1.19
Choose a base branch
from

Conversation

ghassenbenzahra123
Copy link
Contributor

This PR fixes #1403

Screenshot_1735468178

YassinNouh21 and others added 10 commits December 1, 2024 08:16
* fix: Ensure correct Moshaf type (Hafs) is displayed after download

* fix: display Hafs Quran correctly and remove success dialog

- Set Hafs as default Moshaf type if none is selected.
- Auto-dismiss success dialog on download completion.
- Improved state invalidation for Quran reading updates.
- Added FocusNode for better dialog interaction.
- Optimized resource management with keepAlive and link.close().

* fix: improve Quran Download and Navigation Experience

- Redirect user to Quran reading screen automatically after successful download and extraction of Quran (Hafs).
- Remove the unnecessary "OK" button to confirm Quran download completion, streamlining the user experience.
- Enhance state management for download-related UI in `quran_reading_screen.dart` to handle various download states (needed, downloading, extracting).
- Update `download_quran_popup.dart` to ensure proper navigation based on the user's first-time download experience.
- Improve error handling and loading indicators for a smoother and more intuitive flow.

* fix formating
- updated `_handleNavigation` method in `quran_mode_selection_screen.dart` to use `async/await` for ensuring proper completion of Quran mode selection before navigation.
- fixed unexpected pop-ups by adjusting the handling of the `moshafType` state in `download_quran_popup.dart`.
- improved navigation flow for both Reading and Listening modes, ensuring seamless user experience.

Co-authored-by: Ghassen Ben Zahra <ghassen.benzahra@gmail.com>
@ghassenbenzahra123 ghassenbenzahra123 self-assigned this Dec 29, 2024
@ghassenbenzahra123 ghassenbenzahra123 linked an issue Dec 29, 2024 that may be closed by this pull request
@YassinNouh21 YassinNouh21 added the bug Something isn't working label Jan 8, 2025
@YassinNouh21
Copy link
Contributor

YassinNouh21 commented Jan 8, 2025

we have an issue when the Maghrib is after 12

@ghassenbenzahra123

image

@ghassenbenzahra123
Copy link
Contributor Author

we have an issue when the Maghrib is after 12

@ghassenbenzahra123

image

Fixed by latest commit @YassinNouh21

@ghassenbenzahra123 ghassenbenzahra123 changed the base branch from release-1.18.0 to release-1.19 January 8, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Next Prayer Indication After Midnight
3 participants