Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #12280

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Logging fixes #12280

merged 3 commits into from
Jan 4, 2025

Conversation

DonLakeFlyer
Copy link
Contributor

Problems fixed:

  • Joystick code spitting out pile of this qgc.joystick.joysticksdl: Couldn't add GameController mapping: Couldn't parse GUID from # Game Controller DB for SDL in 2.0.16 format
  • Joystick logging getting output even when not turned on
  • PITA to turn off logging categories which are turned on and/or see which ones are on. Have to scroll through a big list

New logging dialog:
Screenshot 2025-01-04 at 9 26 56 AM

@DonLakeFlyer DonLakeFlyer requested a review from HTRamsey January 4, 2025 17:32
@DonLakeFlyer
Copy link
Contributor Author

@HTRamsey I'm pretty sure the gamecontroller reading stuff is right. But you should check.

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 4, 2025

I think there's an SDL command to read a whole file instead of line by line, but otherwise yeah that should be fine too

@DonLakeFlyer DonLakeFlyer merged commit 5a13d66 into master Jan 4, 2025
8 checks passed
@DonLakeFlyer DonLakeFlyer deleted the Logging branch January 4, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants