Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added horizontal value slider support #12274

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Added horizontal value slider support #12274

merged 1 commit into from
Jan 3, 2025

Conversation

DonLakeFlyer
Copy link
Contributor

@DonLakeFlyer DonLakeFlyer commented Jan 3, 2025

This control works exactly like the vertical guided value slider you see during things like a Takeoff action. You can flick it left/right to change the value. And you can click on the value to type in a new value. The goal is to make QGC more mobile friendly, where typing in values can be a real pain with the virtual keyboard. That said it still supports clicking in the value and typing in a value directly if you want to. So hopefully the best of both worlds.

I've converted previous UI which was using the old FactSlider control to use the new control. Here is an example with the battery toolbar indicator:

New
Screenshot 2025-01-02 at 4 42 26 PM

Old
Screenshot 2025-01-02 at 5 29 12 PM

@DonLakeFlyer
Copy link
Contributor Author

@DieBorr This new control is basically a rewritten version of the vertical one. But I wrote it to be much closer to the code needed to make a single control which can do both vertical and horizontal orientations. Once this goes through I'm going to take a look at making that single control. Not quite sure if it will end up being so complex/obfuscated to be worth a single control. But I'm going to try.

@DonLakeFlyer DonLakeFlyer merged commit 5976d7c into master Jan 3, 2025
8 checks passed
@DonLakeFlyer DonLakeFlyer deleted the ValueSlider branch January 3, 2025 17:52
@DieBorr
Copy link
Contributor

DieBorr commented Jan 6, 2025

Hi @DonLakeFlyer sorry for not answering earlier.
Right now I have tested them, and they look so clean with the UI. This type of changes is what the average user values the most when deciding which applications to use. The fact is easier to change the values to more precise points while using the fingers makes it very useful.

P.S.: I'm planning to ask people who usually use other ground stations about which UI features they value the most when deciding to use a ground station. Based on their feedback, I'll try to rework those aspects within QGC. One example is the sliders, which now have a more 'solid/premium' style.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants