Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings (take two) #2297

Merged
merged 19 commits into from
May 25, 2024
Merged

Fix warnings (take two) #2297

merged 19 commits into from
May 25, 2024

Conversation

julianoes
Copy link
Collaborator

Second attempt at this, replacing #2291.

@julianoes julianoes requested a review from JonasVautherin May 8, 2024 22:09
@julianoes julianoes force-pushed the pr-warnings-take-2 branch 3 times, most recently from fef5df6 to de63c54 Compare May 9, 2024 20:48
@julianoes
Copy link
Collaborator Author

Note to self: I need to figure out why the hell gtest doesn't have the same static vs. dynamic build flags and thus fails linking.

@julianoes julianoes force-pushed the pr-warnings-take-2 branch 2 times, most recently from 3884648 to 08c0ec3 Compare May 22, 2024 21:30
@julianoes julianoes mentioned this pull request May 23, 2024
Closed
@julianoes julianoes force-pushed the pr-warnings-take-2 branch from de3aee9 to 43739fe Compare May 23, 2024 22:51
julianoes added 16 commits May 25, 2024 09:48
@julianoes
component_metadata: fix unused warnings
2b10985 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
CI: Enable -Werror again
63da4d0 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
core: fix libCURL deprecation warnings
1076568 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
third_party: get gtest like other dependencies
915aada 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
cmake: fixup compiler flags
d823741 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
cmake: try fixup
19bab04 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
cmake: Fix -Werror for MSVC
c98b408 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
gtest: try to build the same as the library
6f4e6cf 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
gtest: try to get Windows to build
1d65a2b 
According to:
https://github.com/google/googletest/tree/main/googletest#visual-studio-dynamic-vs-static-runtimes
@julianoes
examples: remove warning error on Windows
f6d7c5c
@julianoes
cmake: no warning errors on MSVC
d76e81e
@julianoes
system_tests: fix std::pair type issues
fa5bf77
@julianoes
mavsdk_server: fix warning in gRPC with GCC 13
5ed4dad 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
cmake: ignore GCC 7 ABI changes
3274e62 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
core: fix stringop-truncation warnings
35ae4d3 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
cmake: fix hunter
0284b95 
Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes julianoes force-pushed the pr-warnings-take-2 branch from 581d62f to 36d18e9 Compare May 24, 2024 21:50
@julianoes julianoes force-pushed the pr-warnings-take-2 branch from c2493af to e0eb026 Compare May 25, 2024 02:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
58.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@julianoes julianoes marked this pull request as ready for review May 25, 2024 03:36
@julianoes julianoes merged commit 4c1cac6 into main May 25, 2024
26 of 28 checks passed
@julianoes julianoes deleted the pr-warnings-take-2 branch May 25, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin Awaiting requested review from JonasVautherin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julianoes