Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to resolve issue with integration-test from snapshot #187

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Update to resolve issue with integration-test from snapshot #187

merged 1 commit into from
Oct 26, 2015

Conversation

beebs-systap
Copy link
Contributor

artifacts. Updated the path logic to be consistent with
AbstractDependencyMojo.

I had an issue with a JNI nar artifact that depended on a shared library nar artifact. When I ran with the locally installed version, the integration-test phase worked fine. When I deployed the shared library artifact and downloaded the dependency, the integration-test failed with the dependencies not being added.

I tracked the issue down to the version being used to add the dependency. This PR updates the NarIntegrationTestMojo dependency to be consistent with the version used in the AbstractDependencyMojo.

An example is below.

POM dependency.

                 <dependency>
                        <groupId>my.group</groupId>
                        <artifactId>shared-library</artifactId>
                        <version>1.0-SNAPSHOT</version>
                        <type>nar</type>
                </dependency>

AbstractDependencyMojo unpacks it here:

target/test-nar/shared-library-1.0-SNAPSHOT-x86_64-MacOSX-gpp-shared/lib/x86_64-MacOSX-gpp/shared

NarIntegrationTestMojo tries to find it here:

target/test-nar/shared-library-1.0-20150908.175802-15-x86_64-MacOSX-gpp-shared/lib/x86_64-MacOSX-gpp/shared

because it uses the Maven super class method version. That file doesn't exist and the library path is not modified. This update uses the getBaseVersion method instead.

artifacts.  Updated the path logic to be consistent with
AbstractDependencyMojo.
@buildhive
Copy link

NAR plugin for Maven » nar-maven-plugin #363 SUCCESS
This pull request looks good
(what's this?)

@beebs-systap
Copy link
Contributor Author

Note that this issue only occurs when the SNAPSHOT repository has the "uniqueVersion" attribute set to true.

                <snapshotRepository>
                        <id>my.snapshots</id>
                        <name>my snapshots</name>
                        <url>myurl/maven/snapshots</url>
                        <uniqueVersion>true</uniqueVersion>
                </snapshotRepository>

GregDomjan added a commit that referenced this pull request Oct 26, 2015
Use baseVersion when working with SNAPSHOT in Integration-test
@GregDomjan GregDomjan merged commit bb92d23 into maven-nar:master Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants