issue 105: remove invalid config element.

[benson-basis]

Fix example by removing invalid element.

The example on the usage page had an invalid element: <packageName/>.

[buildhive]

NAR plugin for Maven » nar-maven-plugin #163 SUCCESS
This pull request looks good
(what's this?)

[dscho]

Hmm. When I run git grep '<packageName>', I get four hits, not just one. Should they not be addressed all at the same time?

Furthermore, I suspect that the <packageName> tag actually wants to be a narSystemPackage tag instead of being removed... Thoughts?

[benson-basis]

My bad. Your guess seems reasonable, I'll do more editing this evening and
push another commit.

On Thu, Jun 12, 2014 at 10:36 AM, dscho notifications@github.com wrote:

Hmm. When I run git grep '', I get four hits, not just one.
Should they not be addressed all at the same time?

Furthermore, I suspect that the tag actually wants to be
a narSystemPackage tag instead of being removed... Thoughts?

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

[bimargulies]

I think I covered it this time.

[ctrueden]

@bimargulies @benson-basis Note that rather than reverting commits on a topic branch, you can just squash them away with git rebase -i. Delete the df2fd8e and a732ae6 lines in your text editor and they'll be stricken from the branch. Then you can git push --force to push just the good commit (the one formerly known as 4ff0241) back to the branch, and the PR will update accordingly.

[benson-basis]

OK, it that's the preferred scheme here, I'll do it. Everyone seems to have
a different preference, is this project's written down?

On Thu, Jun 12, 2014 at 2:02 PM, Curtis Rueden notifications@github.com
wrote:

@bimargulies https://github.com/bimargulies @benson-basis
https://github.com/benson-basis Note that rather than reverting commits
on a topic branch, you can just squash them away with git rebase -i.
Delete the df2fd8e and a732ae6 lines in your text editor and they'll be
stricken from the branch. Then you can git push --force to push just
the good commit (4ff0241) back to the branch, and the PR will update
accordingly.

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

[ctrueden]

Thanks @benson-basis!

[buildhive]

NAR plugin for Maven » nar-maven-plugin #172 SUCCESS
This pull request looks good
(what's this?)

[ctrueden]

As for documenting the preferred process: unfortunately, we haven't documented specifics like "squashing preferred" etc.

[dscho]

OK, it that's the preferred scheme here, I'll do it. Everyone seems to have a different preference, is this project's written down?

If you want to be able to use Git effectively, including powerful commands such as git bisect, there is actually no alternative to rewriting topic branches rather than adding commit on commit only to fix up problems introduced by earlier changes in the same topic branch. Otherwise, you'll be in for a lot of pain when you try to bisect even the most trivial bugs.

[bimargulies]

You don't have to convince me, just tell me what you prefer.

On Thu, Jun 12, 2014 at 2:38 PM, dscho notifications@github.com wrote:

OK, it that's the preferred scheme here, I'll do it. Everyone seems to
have a different preference, is this project's written down?

If you want to be able to use Git effectively, including powerful commands
such as git bisect, there is actually no alternative to rewriting topic
branches rather than adding commit on commit only to fix up problems
introduced by earlier changes in the same topic branch. Otherwise, you'll
be in for a lot of pain when you try to bisect even the most trivial
bugs.

—
Reply to this email directly or view it on GitHub
#110 (comment)
.

[buildhive]

NAR plugin for Maven » nar-maven-plugin #174 SUCCESS
This pull request looks good
(what's this?)