-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Additional Features / Options #563
Conversation
Add: Feature Table Add: Links Add: TOC Fix: References for TOC
Do you want to add some of them into .travis.yaml? |
I'd like to say for everyone that see this PR, I will not promise that the options will stable in feature. I possibly may include some of them into default feature. :) |
And I regret that these some tags should have sqlite3- prefix. If possible, I want to the tags which does not have the prefix of sqlite3- be deprecated. |
I understand and agree. I will add them to I understand that some options will be enabled by default in the future, but some should be left to the user, or we should follow SQLite itself. For example; foreign keys check is still not enabled by default by SQLite itself. So should we not follow the same convention ? Let me know DeprecationTo make sure I understand you completly, you want to deprecate the tag; I will make the changes you want. |
Thanks. So I want to rename all of opt tags include . Could you please add fts5 => sqlite_fts5 fts5 I'll keep older tag name for the time being to be possible to build with both tags. And I'll make the feature-tags which doesn't include sqlite_ prefix deprecated. |
One more please, update .travis.yml with using new |
* Keep current build tags backwards compliant * Added alias for `sqlite_json1` => `sqlite_json`
Fix: New build tag(s) names
Add documentation to feature table for tag `trace`
Usage of new build tag names
@mattn I've renamed everything to what you wanted. Updates
|
Added Cross-Compile jobs for additional feature(s)
Travis CI now fully updated, forgot to add the additional jobs for the Windows Cross-Compile. |
Thanks. I'll merge this after CI succeeded. |
You will update the |
No, that was garbage. Thanks. |
Then I suggest we leave the |
@mattn on OSX module ICU fails: |
Required for building SQLite module `icu`
now travis stop? |
Yeah stop Travis. I will make it shorter |
@mattn Travis-CI Updated, currently running hope that you can merge this PR when its done. |
Closes mattn#567
@mattn Still trouble with compiling the |
@gjrtimmer Thanks your working on this. Sorry, I don't have OSX. So can not help you... |
@mattn I'm now trying with Stackoverflow to fix this. |
@mattn Think I succesfully fixed it, will merge my For the |
Removed: 32Bit Windows Cross-Compile Aggregated: sqlite_trace into main module build
@mattn Build successful |
@mattn Ready to merge 👍 |
Thanks. I'll check this on Windows later. |
LGTM on Windows. Thank you. |
New README Preview
ADD
Update