Warning and note in sqlite3-binding.c #803

KrisCarr · 2020-04-14T17:52:12Z

Every time my application starts or tests are run I get the following in my output:

# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~

I can get round this by adding -w to the CFLAGS option inside sqlite3.go

Is there a better way to get rid of this warning and note?

I am running on Fedora 32 x86_64

The text was updated successfully, but these errors were encountered:

KrisCarr · 2020-04-14T18:14:21Z

I have added -Wno-return-local-addr" to my environment variables in .bashrc which has got rid of all that mess for the time being.

export CGO_CFLAGS="-g -O2 -Wno-return-local-addr"

james-d-elliott · 2020-05-07T23:15:33Z

A user of a product I am one of the maintainers for complained about the same thing. If you're able I'm interested in your gcc, glibc, and libsqlite3 versions; as it works fine for me.

For ref my versions are 9.3, 2.31, and 3.31.1

pgnd · 2020-05-08T03:22:56Z

with

sqlite3 --version
	3.31.1 2020-01-27 19:55:54 3bfa9cc97da10598521b342961df8f5f68c7388fa117345eeb516eaa837balt1

build with gcc10

	echo $CC $CXX $CPP
		/usr/bin/gcc-10 /usr/bin/g++-10 /usr/bin/cpp-10
	$CC --version
		gcc-10 (SUSE Linux) 10.1.1 20200507 [revision dd38686d9c810cecbaa80bb82ed91caaa58ad635]
	go build github.com/mattn/go-sqlite3
		# github.com/mattn/go-sqlite3
		sqlite3-binding.c: In function ‘sqlite3SelectNew’:
		sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
		128049 |   return pNew;
		       |          ^~~~
		sqlite3-binding.c:128009:10: note: declared here
		128009 |   Select standin;
		       |          ^~~~~~~

and, build with gcc9

	echo $CC $CXX $CPP
		/usr/bin/gcc-9 /usr/bin/g++-9 /usr/bin/cpp-9
	$CC --version
		gcc-9 (SUSE Linux) 9.3.1 20200406 [revision 6db837a5288ee3ca5ec504fbd5a765817e556ac2]
	go build github.com/mattn/go-sqlite3

=====> NO SQLITE3 ERROR <====

james-d-elliott · 2020-05-08T03:33:39Z

Yeah, looks like a gcc 10 issue, 9.3 works fine. It's likely the issue lies with libsqlite3-0 3.31.1 and gcc 10.x. Either a new warning being detected or a problem with 10.x - a lot of issues were resolved in 10.1 marked as regressions introduced between 9.3 and 10.0 (~700) so it could be that.

pgnd · 2020-05-08T03:58:57Z

looks likely

git clone https://github.com/sqlite/sqlite.git
cd sqlite
git checkout version-3.31.1
gcc --version
	gcc (SUSE Linux) 10.1.1 20200507 [revision dd38686d9c810cecbaa80bb82ed91caaa58ad635]
./configure
make
	...
	libtool: link: /usr/bin/gcc-10 -O3 -Wall -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fmessage-length=0 -grecord-gcc-switches -march=native -mtune=native -D_FORTIFY_SOURCE=2 -O3 -Wall -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fmessage-length=0 -grecord-gcc-switches -march=native -mtune=native -DSQLITE_OS_UNIX=1 -I. -I/usr/local/src/sqlite/src -I/usr/local/src/sqlite/ext/rtree -I/usr/local/src/sqlite/ext/icu -I/usr/local/src/sqlite/ext/fts3 -I/usr/local/src/sqlite/ext/async -I/usr/local/src/sqlite/ext/session -I/usr/local/src/sqlite/ext/userauth -D_HAVE_SQLITE_CONFIG_H -DBUILD_sqlite -DNDEBUG -DSQLITE_THREADSAFE=1 -DSQLITE_HAVE_ZLIB=1 -DHAVE_READLINE=0 -DHAVE_EDITLINE=1 -DSQLITE_ENABLE_JSON1 -DSQLITE_ENABLE_FTS4 -DSQLITE_ENABLE_RTREE -DSQLITE_ENABLE_EXPLAIN_COMMENTS -DSQLITE_ENABLE_UNKNOWN_SQL_FUNCTION -DSQLITE_ENABLE_STMTVTAB -DSQLITE_ENABLE_DBPAGE_VTAB -DSQLITE_ENABLE_DBSTAT_VTAB -DSQLITE_ENABLE_OFFSET_SQL_FUNC -DSQLITE_ENABLE_DESERIALIZE -o sqlite3 shell.c sqlite3.c  -ledit -ldl -lz -lpthread -Wl,-rpath -Wl,/usr/local/sqlite-gcc10-test/lib64
	In function 'zipfileComparePath',
	    inlined from 'zipfileUpdate' at shell.c:5784:11:
	shell.c:5656:17: warning: '__builtin_memcmp_eq' specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
	 5656 |   if( nA==nB && memcmp(zA, zB, nA)==0 ) return 0;
	      |                 ^~~~~~~~~~~~~~~~~~
	sqlite3.c: In function ‘sqlite3SelectNew’:
	sqlite3.c:128048:10: warning: function may return address of local variable [-Wreturn-local-addr]
	128048 |   return pNew;
	       |          ^~~~
	sqlite3.c:128008:10: note: declared here
	128008 |   Select standin;
	       |          ^~~~~~~
	sqlite3.c:128008:10: note: declared here
	sqlite3.c: In function 'sqlite3SelectNew':
	sqlite3.c:128048:10: warning: function may return address of local variable [-Wreturn-local-addr]
	128048 |   return pNew;
	       |          ^~~~
	sqlite3.c:128008:10: note: declared here
	128008 |   Select standin;
	       |          ^~~~~~~
	sqlite3.c:128008:10: note: declared here
	...

rbucker · 2020-05-15T16:04:19Z

In my case...

$ go get -u -v github.com/mattn/go-sqlite3
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~

ClearLinux version:

$ swupd check-update 
Current OS version: 33100
Latest server version: 33100
There are no updates available

GCC Version

$ gcc --version
gcc (Clear Linux OS for Intel Architecture) 10.1.1 20200513 releases/gcc-10.1.0-36-gf2b77b928a
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

ghost · 2020-05-18T02:13:04Z

windows 10 x64 2004 has the same issue

james-d-elliott · 2020-05-18T03:23:09Z

This is an upstream bug with libsqlite3, not sure where their bug tracker is.

subpop · 2020-05-18T13:26:44Z

This is an upstream bug with libsqlite3, not sure where their bug tracker is.

https://www3.sqlite.org/cgi/src/ticket

LawnGnome · 2020-05-27T21:00:17Z

There's a discussion on the SQLite Forum about this issue, including a candidate patch.

payloadartist · 2021-03-03T07:48:30Z

Facing this issue with GoORM, which uses this sqlite3 driver. Any workarounds?

Update - adding this env variable fixed it, export CGO_CFLAGS="-g -O2 -Wno-return-local-addr"

edo1 · 2021-04-29T17:46:00Z

fixed in sqlite3 release 3.33, so go-sqlite3 1.14.1 and later doesn't have this issue

P. S. actual go-sqlite3 release is 1.14.7, not 2.0.x

qweccc · 2021-05-06T01:21:01Z

export CGO_CFLAGS="-g -O2 -Wno-return-local-addr"

itz work

awfulcooking · 2021-10-28T14:42:52Z

Don't disable these warnings, people. You want to see them.

It's like seeing a small fire, closing your eyes and pretending it's not there!

pablodz · 2022-02-07T21:22:17Z

Don't disable these warnings, people. You want to see them.

It's like seeing a small fire, closing your eyes and pretending it's not there!

You have described the whole tech industry

ghost · 2022-08-11T20:44:27Z

Hello I am facing the same problem while I try to install gophish.
I use sudo go install github.com/gophish/gophish@latest ( Because get is deprecated from go dependecies and should add the value @latest or version.

github.com/mattn/go-sqlite3

sqlite3-binding.c: In function ‘sqlite3SelectNew’:
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 | return pNew;
| ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 | Select standin;
| ^~~~~~~
This is the error I get. Please is there any workaround?

rittneje · 2022-08-11T20:50:18Z

@shalota1 gophish is using v2.0.3 of this library, which is quite old. You will need to ask the maintainer to upgrade to the latest version (v1.14.14) and try that.

PetengDedet · 2022-09-17T05:14:03Z

For Windows user

go env -w CGO_CFLAGS="-g -O2 -Wno-return-local-addr"

Attempt fix by mattn/go-sqlite3#803 (comment)

mvikrammenon · 2023-04-26T05:23:57Z

@shalota1 gophish is using v2.0.3 of this library, which is quite old. You will need to ask the maintainer to upgrade to the latest version (v1.14.14) and try that.

Thanks for pointing it out. Tried go get github.com/mattn/go-sqlite3@v1.14.16 and that updated few dependencies. Able to build successfully in my Amazon Linux box.
Have raised a PR with fix. gophish/gophish#2848

rytcnt · 2023-05-10T19:48:44Z

@shalota1 gophish is using v2.0.3 of this library, which is quite old. You will need to ask the maintainer to upgrade to the latest version (v1.14.14) and try that.

Thanks for pointing it out. Tried go get github.com/mattn/go-sqlite3@v1.14.16 and that updated few dependencies. Able to build successfully in my Amazon Linux box. Have raised a PR with fix. gophish/gophish#2848

Thanks - I was able to use your proposed fixes to the go.mod and go.sum files, after doing a git clone https://github.com/gophish/gophish.git then a go build in the directory once the two files were modified. For some reason the go get command didn't work, nor did the go install commands.

The version of go-sqlite3 we are currently using (v1.10.0) generates a warning from the C compiler on many go commands (like go build, go test, go vet, etc): # github.com/mattn/go-sqlite3 sqlite3-binding.c: In function ‘sqlite3SelectNew’: sqlite3-binding.c:123303:10: warning: function may return address of local variable [-Wreturn-local-addr] 123303 | return pNew; | ^~~~ sqlite3-binding.c:123263:10: note: declared here 123263 | Select standin; | ^~~~~~~ This change updates go-sqlite3 to the latest version (v1.14.16), which was fixed to avoid this warning; see: mattn/go-sqlite3#803 https://sqlite.org/forum/forumpost/e39020f82d7d510ea4d4a08ae370ca8df061c8b91884c82fda4897853faa2096

Update the go-sqlite3 module to receive that fix for mattn/go-sqlite3#803 which has started occuring since the build machinary was updated.

* chore(deps): update github.com/mattn/go-sqlite3 Update the go-sqlite3 module to receive that fix for mattn/go-sqlite3#803 which has started occuring since the build machinary was updated. * fix: lint * chore: update staticcheck to support newer go versions * fix: staticcheck * fix: go error formatting * chore: increase benchmark timeout

mattn/go-sqlite3#803

rittneje · 2024-03-03T05:11:17Z

Closing because I believe this issue has long since been fixed in SQLite itself.

stlaz mentioned this issue May 28, 2020

compiling oc with gcc 10.x throws warnings openshift/oc#441

Closed

vzool mentioned this issue Jun 7, 2020

[WARNING] sqlite3-binding.c: In function ‘sqlite3SelectNew’ #822

Open

aquarapid mentioned this issue Aug 26, 2020

Compile warnings with new go-sqlite3 dep vitessio/vitess#6631

Closed

benarent mentioned this issue Nov 9, 2020

sqlite3-binding.c warnings: When using gcc 10.2.0 gravitational/teleport#4760

Closed

bcmills mentioned this issue Dec 2, 2020

x/perf: build failures due to C compiler warnings in github.com/mattn/go-sqlite3 golang/go#42941

Closed

edo1 mentioned this issue Apr 24, 2021

Update go-sqlite3 version to ommit warnings russross/meddler#26

Closed

stunndard mentioned this issue Apr 30, 2021

fix sqlite3-related build warnings hermeznetwork/hermez-node#767

Merged

stelb mentioned this issue Jul 14, 2021

cannot compile on Fedora 34 joohoi/acme-dns#267

Open

BenElgar mentioned this issue Sep 24, 2021

Sqlite logs deref/exo#358

Merged

mjlshen mentioned this issue Nov 27, 2021

go-sqlite3 warnings kubeedge/kubeedge#3391

Closed

dbussink mentioned this issue Jul 28, 2022

Tweak make targets MacOS M1 xc to Linux arches vitessio/vitess#10706

Merged

3 tasks

This was referenced Sep 13, 2022

Forbidden - referer invalid gophish/gophish#2589

Closed

Gophish doesn’t want to work on aarch64 gophish/gophish#2600

Closed

atoulme mentioned this issue Nov 2, 2022

[extension/storage/dbstorage] Flaky Test open-telemetry/opentelemetry-collector-contrib#11451

Closed

cr0wm4n mentioned this issue Nov 21, 2022

tried loads following this on ubuntu IndrekHaav/photoprism-debian#9

Closed

atoulme mentioned this issue Mar 2, 2023

[chore] Remove sqlite compilation warnings open-telemetry/opentelemetry-collector-contrib#19152

Closed

This was referenced Mar 4, 2023

Bump go-sqlite3 zk-org/zk#296

Merged

Error when building from scratch zk-org/zk#295

Closed

tie mentioned this issue Mar 10, 2023

pufferpanel: 2.2.0 -> v2.6.6 NixOS/nixpkgs#220407

Closed

12 tasks

mvikrammenon added a commit to mvikrammenon/gophish that referenced this issue Apr 26, 2023

Update go-sqlite version

ec2cd44

Attempt fix by mattn/go-sqlite3#803 (comment)

mhilton added a commit to influxdata/flux that referenced this issue Nov 21, 2023

chore(deps): update github.com/mattn/go-sqlite3

e4e050b

Update the go-sqlite3 module to receive that fix for mattn/go-sqlite3#803 which has started occuring since the build machinary was updated.

mhilton mentioned this issue Nov 21, 2023

chore(deps): update github.com/mattn/go-sqlite3 influxdata/flux#5444

Merged

5 tasks

timabell mentioned this issue Jan 27, 2024

Add tests in github-actions timabell/schema-explorer#62

Closed

dude333 added a commit to dude333/rapina that referenced this issue Feb 20, 2024

Remove warning messages from C compiler

9843d89

mattn/go-sqlite3#803

rittneje closed this as completed Mar 3, 2024

briancain mentioned this issue Jul 25, 2024

Update github.com/mattn/go-sqlite3 to newer version hashicorp/go-dbw#56

Closed

gkeesh7 mentioned this issue Sep 24, 2024

Adding CGO flags to supress warnings and fix build failures uber/kraken#364

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning and note in sqlite3-binding.c #803

Warning and note in sqlite3-binding.c #803

KrisCarr commented Apr 14, 2020

KrisCarr commented Apr 14, 2020

james-d-elliott commented May 7, 2020 •

edited

Loading

pgnd commented May 8, 2020

james-d-elliott commented May 8, 2020 •

edited

Loading

pgnd commented May 8, 2020

rbucker commented May 15, 2020

ghost commented May 18, 2020

james-d-elliott commented May 18, 2020

subpop commented May 18, 2020

LawnGnome commented May 27, 2020

payloadartist commented Mar 3, 2021 •

edited

Loading

edo1 commented Apr 29, 2021

qweccc commented May 6, 2021

awfulcooking commented Oct 28, 2021

pablodz commented Feb 7, 2022

ghost commented Aug 11, 2022

rittneje commented Aug 11, 2022

PetengDedet commented Sep 17, 2022

mvikrammenon commented Apr 26, 2023 •

edited

Loading

rytcnt commented May 10, 2023

rittneje commented Mar 3, 2024

Warning and note in sqlite3-binding.c #803

Warning and note in sqlite3-binding.c #803

Comments

KrisCarr commented Apr 14, 2020

KrisCarr commented Apr 14, 2020

james-d-elliott commented May 7, 2020 • edited Loading

pgnd commented May 8, 2020

james-d-elliott commented May 8, 2020 • edited Loading

pgnd commented May 8, 2020

rbucker commented May 15, 2020

ghost commented May 18, 2020

james-d-elliott commented May 18, 2020

subpop commented May 18, 2020

LawnGnome commented May 27, 2020

payloadartist commented Mar 3, 2021 • edited Loading

edo1 commented Apr 29, 2021

qweccc commented May 6, 2021

awfulcooking commented Oct 28, 2021

pablodz commented Feb 7, 2022

ghost commented Aug 11, 2022

github.com/mattn/go-sqlite3

rittneje commented Aug 11, 2022

PetengDedet commented Sep 17, 2022

mvikrammenon commented Apr 26, 2023 • edited Loading

rytcnt commented May 10, 2023

rittneje commented Mar 3, 2024

james-d-elliott commented May 7, 2020 •

edited

Loading

james-d-elliott commented May 8, 2020 •

edited

Loading

payloadartist commented Mar 3, 2021 •

edited

Loading

mvikrammenon commented Apr 26, 2023 •

edited

Loading