Rename OptimalStringAlignement to OptimalStringAlignment
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is a misspelling of the latter: note the extra 'e' in "alignement." In renaming this, I've used `deprecate_binding` which correctly handles deprecations for types as well as exporting. I've also corrected two issues with the docstring for this type: - The whole docstring was indented by 4 spaces, which Markdown interprets as a code block, so the whole docstring was code-quoted. - The docstring erroneously said that OSA is the unrestricted D-L distance, but it's actually the restricted D-L distance.
|
Great PR, thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is a misspelling of the latter: note the extra 'e' in "alignement." In renaming this, I've used
deprecate_bindingwhich correctly handles deprecations for types as well as exporting.I've also corrected two issues with the docstring for this type: