Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #14

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Update dependencies #14

merged 3 commits into from
Nov 23, 2024

Conversation

matthew-dong-dev
Copy link
Owner

@matthew-dong-dev matthew-dong-dev commented Nov 23, 2024

What are the changes and why are they needed?

  • be able to run app locally, can no longer run bundle install with current version of gemfile.lock, not compatible with default ruby in ubuntu 20.04
  • instead of installing older version of ruby & bundler - using newer versions that are no longer EOL

How has this been tested?

  • app runs in local environment after changing ruby version with rbenv
  • app builds and runs with docker

@matthew-dong-dev matthew-dong-dev linked an issue Nov 23, 2024 that may be closed by this pull request
@@ -3,3 +3,4 @@ source 'http://rubygems.org'
gem 'github-pages'
gem 'html-proofer'
gem 'jekyll-admin'
gem "sinatra", ">= 3", "< 4"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthew-dong-dev matthew-dong-dev merged commit 89ffa92 into master Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix app to be able to run in new ruby environment
1 participant