Fix issue of settings command working for non-connected users #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
approved these changes
Jul 2, 2024
Comment on lines
+264
to
+271
| if _, authErr := p.authenticateAndFetchZoomUser(user); authErr != nil { | ||
| // the user state will be needed later while connecting the user to Zoom via OAuth | ||
| if appErr := p.storeOAuthUserState(user.Id, args.ChannelId, false); appErr != nil { | ||
| p.API.LogWarn("failed to store user state") | ||
| } | ||
| return authErr.Message, authErr.Err | ||
| } | ||
|
|
There was a problem hiding this comment.
What's the message that's shown here?
There was a problem hiding this comment.
@mickmister User is shown a link to connect the account if it is not connected. It is the same flow as when the user tries to start meeting while not being connected
mattermost-plugin-zoom/server/command.go
Line 128 in ae9b924
raghavaggarwal2308
approved these changes
Jul 2, 2024
AayushChaudhary0001
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Fixes #346
What to test?
/zoom settingscommand should not work for non-connected users.Checklist
make testRan test cases and ensured they are passingmake check-styleRan style check and ensured both webapp and server pass the checks