-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-343] Updated meeting flow for new users. #344
Conversation
- User will get a post to select the default meeting ID when they try to start a meeting for the first time.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 18.47% 18.04% -0.44%
==========================================
Files 9 9
Lines 1510 1546 +36
==========================================
Hits 279 279
- Misses 1180 1216 +36
Partials 51 51 ☔ View full report in Codecov by Sentry. |
@raghavaggarwal2308 Can you please post some more screenshots to show the other possible states that we show the user? |
@raghavaggarwal2308 Do we automatically create the zoom meeting and take the user to the zoom meeting page after they select an option? |
@asaadmahmood Added logic to automatically redirect the user to the meeting page and yes, we automatically create the zoom meeting. |
@mickmister For existing users: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems off to me to have the ![]() Thoughts on only showing this on meeting creation, and not account connection? @asaadmahmood |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. I do want the UX question above verified before merging though
@mickmister Fixed the review comments mentioned by you |
The PR above has been tested for the following scenario:-
This PR is working fine for the above condition, LGTM. Approved. |
I'm still thinking we should only show the |
@mickmister @asaadmahmood Gentle reminder for the updates on this PR. |
@mickmister @ayusht2810 Yes, I think we should only show it on meeting creation. |
@mickmister @asaadmahmood updated the statement. Please re-review |
@ayusht2810 Can you show a video. |
@asaadmahmood Demo video for the above fix screen-capture.webm |
LGTM |
@mickmister Can we merge this PR and move forward with release v1.7.1? |
@hanzei Can we merge this PR as it is Dev and QA approved for the release 1.7.1? |
Summary
Screenshots
What to test?
Steps to test:
Ticket Link
Fixes #343
Fixes #341