Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-191] Added typescript setup #342

Closed
wants to merge 8 commits into from
Closed

[MM-191] Added typescript setup #342

wants to merge 8 commits into from

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

Ticket Link

@raghavaggarwal2308 raghavaggarwal2308 marked this pull request as draft February 5, 2024 07:39
@raghavaggarwal2308 raghavaggarwal2308 marked this pull request as ready for review February 5, 2024 08:02
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.41%. Comparing base (7fa5345) to head (c3f6dd9).

❗ Current head c3f6dd9 differs from pull request most recent head 8ebc9e4. Consider uploading reports for the commit 8ebc9e4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   18.47%   18.41%   -0.07%     
==========================================
  Files           9        9              
  Lines        1510     1515       +5     
==========================================
  Hits          279      279              
- Misses       1180     1185       +5     
  Partials       51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ayusht2810
ayusht2810 reviewed Feb 5, 2024
View reviewed changes
webapp/package.json Outdated Show resolved Hide resolved
webapp/webpack.config.js Show resolved Hide resolved
@raghavaggarwal2308
Copy link
Contributor Author

@ayusht2810 Fixed the review comments added by you

mickmister
mickmister approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AayushChaudhary0001
AayushChaudhary0001 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and approved. All the basic features are working fine after the changes, LGTM.

@mickmister mickmister added the 4: Reviews Complete All reviewers have approved the pull request label Mar 14, 2024
@mickmister
Copy link
Contributor

@raghavaggarwal2308 There are conflicts to resolve here

@raghavaggarwal2308
Copy link
Contributor Author

@mickmister I think @ayusht2810 has alredy added the typescript setup here #333. Thoughts on closing this PR?

@mickmister mickmister closed this Mar 14, 2024
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-191 branch March 15, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raghavaggarwal2308 @mickmister @ayusht2810 @AayushChaudhary0001