Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image asset name to fix cutplugin command #330

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented Dec 19, 2023

Summary

The asset name zoom-plugin-configuration.png was causing issues with the cutplugin command, likely because it contains the word "plugin". This PR changes the image name to avoid this conflict.

Error while signing plugin
Error: failed to create platform tars: found wrong platform binary in /tmp/zoom-1.7.0.tar.gz1009784493/mattermost-plugin-zoom-v1.7.0-rc1-osx-amd64.tar.gz, expected plugin-darwin-amd64, but found [plugin-darwin-amd64 zoom-plugin-configuration.png]

I don't see where this file (or other files from the assets folder) are being used. I see links in the README like https://github.com/mattermost/mattermost-plugin-zoom/assets/74422101/3928708d-8b57-474b-9c4a-d1e21c054d31 that seem to reference images in the assets folder, though I don't know how to verify which file it's accessing, and I don't know if I will break anything by renaming/removing images files. I don't see the name of the file zoom-plugin-configuration.png (or most of the files in the assets folder) being used anywhere in the repo, so it seems there is nothing using it but I'm not sure.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/CLD-6689

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9e6123) 18.86% compared to head (1a5559d) 18.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   18.86%   18.86%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          279      279           
  Misses       1149     1149           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Contributor Author

mickmister commented Dec 19, 2023

With regards to the image references in the README, none of them seem to be referencing the checked-in images directly. I'm going to convert the ones being used into checked-in files, and get rid of any checked-in files that are not being referenced in the repository.

@mickmister
Copy link
Contributor Author

I don't want to complicate this PR though. This is meant to unblock the RC build issue

@mickmister mickmister requested a review from hanzei December 19, 2023 20:46
@raghavaggarwal2308
Copy link
Contributor

@mickmister We have created PR against the master to fix the failing CI here. We can sync this PR once that is merged.
#332

@avas27JTG
Copy link
Contributor

@mickmister We have created PR against the master to fix the failing CI here. We can sync this PR once that is merged. #332

I've done this

@mickmister mickmister merged commit 925f6f9 into master Dec 22, 2023
9 checks passed
@mickmister mickmister deleted the fix-asset-name branch December 22, 2023 18:47
@avas27JTG avas27JTG mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants