Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check nil license features #277

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Check nil license features #277

merged 1 commit into from
Aug 9, 2022

Conversation

mickmister
Copy link
Contributor

Summary

Ticket Link

Fixes #276

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 8, 2022
@mickmister mickmister requested a review from larkox as a code owner August 8, 2022 18:46
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #277 (310a533) into master (dec2ad9) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #277   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         906     906           
======================================
  Misses        906     906           
Impacted Files Coverage Δ
server/plugin.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Tested with on Prem, and Cloud as well as no license file
  • Tested launching meeting
  • No crash reproduces

LGTM!

This is needed for the v1.6.1 branch.

@DHaussermann DHaussermann added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Aug 8, 2022
@mickmister mickmister merged commit a6c01ce into master Aug 9, 2022
@mickmister mickmister deleted the check-nil-license-fields branch August 9, 2022 00:36
mickmister added a commit that referenced this pull request Aug 9, 2022
@mickmister mickmister mentioned this pull request Aug 9, 2022
mickmister added a commit that referenced this pull request Aug 16, 2022
* Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin (#237)

Co-authored-by: maisnamrajusingh <raju.s@demansol.com>

* [MM-223] Fixing Post Permissions Access (#233)

* For non-cloud plugin settings, set hosting property to `on-prem` (#269)

* set hosting to on-prem for `Enable OAuth`, `APIKey`, and `APISecret` plugin settings

* use actual server commit

* force oauth to be used when using cloud version of the plugin

* bump go mod version

* test circleci config

* remove references to plugin-ci

* bump Go version in circleci

* use cimg

* add other cimg changes

* go mod tidy

* revert circleci changes

* revert build/go.mod changes so we are using the old server version

* extend manifest struct to support hosting field

* Revert "extend manifest struct to support hosting field"

This reverts commit b862b40.

* revert all go mod changes

* remove manifest field name restriction

* add comment explaining commented out code

* reorder conditions for readability

* Fix OAuth token refresh (#253)

* avoid refreshing token if an error occurs while fetching current token

* pass in firstConnect bool

* lint

* explicitly assign firstConnect boolean to local variable

* ensure oauth token is decrypted when fetched from the kv store

* rename functions

* wrap account level token refresh in firstConnect block as well

* Cherrypick "Correct docs and cleanup screenshots"

* Revert "Cherrypick "Correct docs and cleanup screenshots""

This reverts commit 7164075.

* preserve access token when saving encrypted version

* use refresh token for check

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>

* bump to 1.6.1

* add GetLicense call in test

* check nil license features (#277)

Co-authored-by: sibasankarnayak <86650698+sibasankarnayak@users.noreply.github.com>
Co-authored-by: maisnamrajusingh <raju.s@demansol.com>
Co-authored-by: Jupri Abel <88376482+vicky-demansol@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Co-authored-by: Daniel Espino García <larkox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-prem license causes error when checking for Cloud license
3 participants