-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom installation docs update #245
Conversation
Changes for #230.
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 8 8
Lines 882 882
======================================
Misses 882 882 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. LGTM, just small comments, but nothing blocking.
* Users don't need to authorize their Zoom accounts before starting their first Zoom meeting. The only requirement is that their Mattermost account uses the same email address as their Zoom account. | ||
* Users can't connect their Mattermost/Zoom accounts if their emails do not match. | ||
* **User-level app** | ||
* Each user needs to connect their Zoom account with their Mattermost account before they can use the integration. When they try to create a meeting for the first time, they'll receive a message to connect their account, and will need to click **Approve** on the pop-up confirmation notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if worth it, but the actual flow is:
- They try to create a meeting
- They must follow a link
- The link will redirect to a zoom owned website
- On this site, if they are not logged in, they will be asked to log in into zoom
- Once they are logged in, they will see the "approve" button.
Probably with what is already written, everything is clear, but wanted to make sure.
This PR removes reverences to a previously removed 'enable password based authentication' toggle in the setup documentation. It also replaces the image of the settings. Fixes: #229