Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The already started meeting is not aware of if the meeting stared in the last 30 seconds has ended #373

Closed
raghavaggarwal2308 opened this issue Apr 24, 2024 · 2 comments · Fixed by #390
Milestone

Comments

@raghavaggarwal2308
Copy link
Contributor

raghavaggarwal2308 commented Apr 24, 2024

More information here:
https://community.mattermost.com/core/pl/xh1k4upb6ff8jni8cuzeyw9wqy

Steps to reproduce:

  1. Start a zoom meeting in a channel.
  2. End the above meeting and try to start a new meeting within 30 seconds.

Expected behavior:
A new meeting is started

Current behaviour:
Getting a post with the message that a meeting was recently created in the channel.

@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.9.0 milestone Jul 2, 2024
@Kshitij-Katiyar
Copy link
Contributor

@mickmister @wiggin77
when a meeting-ended notification is received from the webhook, we update the post's meeting_status prop.
If we add the following check in the checkPreviousMessage function, we can resolve this issue.

meetingStatus := getString("meeting_status", post.Props)
if meetingStatus == zoom.WebhookStatusEnded {
    continue
}

However, this fix has one limitation: it will only work if the user has successfully set up the webhook.

Is this approach fine? Should we go ahead and implement this?

@mickmister
Copy link
Contributor

However, this fix has one limitation: it will only work if the user has successfully set up the webhook.

@Kshitij-Katiyar The core feature depends on the webhook anyway right? Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants