Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom plugin while viewing a thread in the Threads view causes a JS error #300

Closed
devinbinnie opened this issue Aug 28, 2023 · 5 comments · Fixed by #307
Closed

Zoom plugin while viewing a thread in the Threads view causes a JS error #300

devinbinnie opened this issue Aug 28, 2023 · 5 comments · Fixed by #307
Labels
Type/Bug Something isn't working

Comments

@devinbinnie
Copy link
Member

Steps to reproduce:

  1. Have CRT enabled, and open the Threads view
  2. Open a thread that pops into the RHS
  3. Click the Zoom button on the right

Expected: Zoom meeting should post into the thread
Observed: Zoom meeting isn’t posted and a JS error occurs

Uncaught TypeError: Cannot read properties of undefined (reading 'id')
    at Object.action (zoom_249d6071dc514b5a_bundle.js:2:360339)
    at onClick (app_bar_plugin_component.tsx:113:21)
    at Object.Be (react-dom.production.min.js:52:317)
    at Ke (react-dom.production.min.js:52:471)
    at react-dom.production.min.js:53:35
    at Pr (react-dom.production.min.js:100:68)
    at Nr (react-dom.production.min.js:101:380)
    at react-dom.production.min.js:113:65
    at De (react-dom.production.min.js:292:189)
    at react-dom.production.min.js:50:57
@Kshitij-Katiyar
Copy link
Contributor

@devinbinnie I tested this bug on mattermost version 8.0.1 and was unable to reproduce it. Please share your mattermost server version.

@Kshitij-Katiyar
Copy link
Contributor

@devinbinnie Currently the meeting link is posted directly to the channel even if a thread is open. Would you like the meeting link to be posted in the thread?
@mickmister Can you share your views on this?

@Kshitij-Katiyar Kshitij-Katiyar added the Type/Bug Something isn't working label Sep 5, 2023
@devinbinnie
Copy link
Member Author

@Kshitij-Katiyar I noticed this cropping up on the community server, so the server version will be the latest master. Not sure which version of the Zoom plugin it's on, but I'm assuming it's also the latest.

I would expect the meeting like to be posted to the thread if possible, especially if we're in Threads view and there is not technically an active channel.

@mickmister
Copy link
Contributor

@Kshitij-Katiyar Note that the "Threads" view is different from opening a thread in the RHS in the regular chat view. You need to click "Threads" button in the top left corner of the UI, and then click the Zoom icon.

@Kshitij-Katiyar
Copy link
Contributor

@mickmister While debugging the error above, I looked into the Mattermost Redux state. I found that the currentChannelId is null in the threads view, which is causing the error. Additionally, there is no currentThreadId object in Redux and no other way to get the currentThreadId or currentChannelId of the currently open thread.

One possible solution is to extract the currentThreadId from the URL. I am currently working on this approach, but please let me know if you have any other suggestions.

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Sep 26, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 12, 2023
…sue mattermost#300 (#7)

* [MI-3560]: Fixed the issue mattermost#300

* [MI-3560]: Removed extra packages

* [MI-3560]: Reverted the changes of package-lock.json
@Kshitij-Katiyar Kshitij-Katiyar moved this from Todo to In Progress in Brightscout Plugin Maintenance Oct 16, 2023
@Kshitij-Katiyar Kshitij-Katiyar moved this from In Progress to Submitted in Brightscout Plugin Maintenance Oct 16, 2023
avas27JTG added a commit that referenced this issue Oct 27, 2023
#307)

* [MI-3560]: Fixed the JS error while posting meeting link to thread issue #300 (#7)

* [MI-3560]: Fixed the issue #300

* [MI-3560]: Removed extra packages

* [MI-3560]: Reverted the changes of package-lock.json

* [MM-00]: Review fixes.

---------

Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
@github-project-automation github-project-automation bot moved this from Submitted / In Review to Done in Brightscout Plugin Maintenance Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
3 participants