-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom plugin while viewing a thread in the Threads view causes a JS error #300
Comments
@devinbinnie I tested this bug on mattermost version 8.0.1 and was unable to reproduce it. Please share your mattermost server version. |
@devinbinnie Currently the meeting link is posted directly to the channel even if a thread is open. Would you like the meeting link to be posted in the thread? |
@Kshitij-Katiyar I noticed this cropping up on the community server, so the server version will be the latest master. Not sure which version of the Zoom plugin it's on, but I'm assuming it's also the latest. I would expect the meeting like to be posted to the thread if possible, especially if we're in Threads view and there is not technically an active channel. |
@Kshitij-Katiyar Note that the "Threads" view is different from opening a thread in the RHS in the regular chat view. You need to click "Threads" button in the top left corner of the UI, and then click the Zoom icon. |
@mickmister While debugging the error above, I looked into the Mattermost Redux state. I found that the One possible solution is to extract the |
…sue mattermost#300 (#7) * [MI-3560]: Fixed the issue mattermost#300 * [MI-3560]: Removed extra packages * [MI-3560]: Reverted the changes of package-lock.json
#307) * [MI-3560]: Fixed the JS error while posting meeting link to thread issue #300 (#7) * [MI-3560]: Fixed the issue #300 * [MI-3560]: Removed extra packages * [MI-3560]: Reverted the changes of package-lock.json * [MM-00]: Review fixes. --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
Steps to reproduce:
Expected: Zoom meeting should post into the thread
Observed: Zoom meeting isn’t posted and a JS error occurs
The text was updated successfully, but these errors were encountered: