Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue of plugin config not prefilling from previous build #1171

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fixed issue of plugin config not prefilling from previous build #1171

merged 2 commits into from
Feb 18, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Fixed the issue of config not prefilling when uploading a new build of release 4.2.0

Testing step

  • Upload release 4.1.1 build
  • Generate and set all plugin config
  • Create & test webhook
  • Upload new build
  • Bool and string configs should be prefilled to the previous configs and webhooks should remain working

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Feb 14, 2025
@Kshitij-Katiyar Kshitij-Katiyar added this to the v4.2.1 milestone Feb 14, 2025
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Feb 14, 2025
wiggin77
wiggin77 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

raghavaggarwal2308
raghavaggarwal2308 requested changes Feb 17, 2025
View reviewed changes
raghavaggarwal2308
raghavaggarwal2308 approved these changes Feb 17, 2025
View reviewed changes
@raghavaggarwal2308 raghavaggarwal2308 added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Feb 17, 2025
@Kshitij-Katiyar @raghavaggarwal2308
Update server/plugin.go
91b13d6 
Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com>
arush-vashishtha
arush-vashishtha approved these changes Feb 17, 2025
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR for plugin configs pre-filling and webhook events being received after updating to v4.2.0 and everything is working fine. LGTM.

@Kshitij-Katiyar Kshitij-Katiyar added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Feb 18, 2025
@Kshitij-Katiyar Kshitij-Katiyar merged commit baf3c84 into master Feb 18, 2025
11 checks passed
@Kshitij-Katiyar Kshitij-Katiyar deleted the fix_release_4.2.0 branch February 18, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Milestone
v4.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308 @arush-vashishtha