Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-1064]: Fixed issue of code block rendering in subscription post #1151

Merged
merged 3 commits into from
Jan 27, 2025
Merged

[MM-1064]: Fixed issue of code block rendering in subscription post #1151

merged 3 commits into from
Jan 27, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Jan 21, 2025 •
edited
Loading

Summary

Fixed the issue of code block rendering in the subscription post

Issue link

Fixes #1154

Screenshots

Screenshot from 2025-01-21 17-57-49
Screenshot from 2025-01-21 18-01-26

@Kshitij-Katiyar Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 21, 2025
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Jan 21, 2025
arush-vashishtha
arush-vashishtha approved these changes Jan 22, 2025
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this fix, and it works fine for the "code blocks" in the comments. LGTM,
image

@Kshitij-Katiyar Kshitij-Katiyar added this to the v4.2.0 milestone Jan 22, 2025
raghavaggarwal2308
raghavaggarwal2308 requested changes Jan 24, 2025
View reviewed changes
server/webhook_parser.go Outdated Show resolved Hide resolved
server/webhook_parser.go Show resolved Hide resolved
raghavaggarwal2308
raghavaggarwal2308 approved these changes Jan 24, 2025
View reviewed changes
server/webhook_parser.go Outdated Show resolved Hide resolved
@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 27, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 35925b4 into master Jan 27, 2025
11 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-1064 branch January 27, 2025 07:56
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v4.2.0
4 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308 @arush-vashishtha