Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-62634] Change the fix for LinkTooltip to be backward compatible for jira plugin #1149

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

M-ZubairAhmed
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed commented Jan 20, 2025

Summary

This fix backports the fix for improved link tooltip to work with version prior to MM v10.5 as well. The minimum MM version for plugin is also reverted back to v7.8. Changes adds more lifecycle hooks one for 10.5 and other for less than that.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-62634

Screenshots

With v10.5
CleanShot 2025-01-20 at 21 28 59

With less than v10.5
CleanShot 2025-01-20 at 21 44 31

@wiggin77 wiggin77 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 20, 2025
@M-ZubairAhmed M-ZubairAhmed changed the title fix [MM-62634] Change the fix for LinkTooltip to be backward compatible for jira plugin Jan 20, 2025
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amyblais amyblais removed the 2: Dev Review Requires review by a core committer label Jan 24, 2025
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and the link tooltip works fine for both the versions of MM above 10.5 and below 10.5(here tested at 9.11.8) and the functionality is working fine, LGTM. Also, the subscriptions are also working fine, Approved.

@M-ZubairAhmed M-ZubairAhmed added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 26, 2025
@M-ZubairAhmed M-ZubairAhmed merged commit d9214df into master Jan 26, 2025
11 checks passed
@M-ZubairAhmed M-ZubairAhmed deleted the backport-version-linktooltip branch January 26, 2025 02:59
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.2.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants