Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-73]: Fixed the issue of getting invalid start/end time even though they were set #79

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented May 31, 2024

Summary

The start/end time was auto-selected when we opened the modal to create an event but still got the error that they were invalid. So fixed it by removing the autoselected value.

Ticket Link

Fixes #73

Ticket Link

  1. Run /gcal event create
  2. Update the subject and click on submit, the meeting should be created.

@mickmister mickmister requested a review from fmartingr May 31, 2024 13:55
@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 31, 2024
@mickmister
Copy link
Contributor

mickmister commented May 31, 2024

Alternatively we could have the initial/default value be given by the parent component. If the UX flow for the empty value seems fine then we can keep that solution

Edit: I didn't mean to close the PR

@mickmister mickmister closed this May 31, 2024
@mickmister mickmister reopened this May 31, 2024
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good enough compromise. 👍

@mickmister
Copy link
Contributor

@matthewbirtch When the "create event" modal is opened, what value should be shown in the "end time" date selector initially? Should be filled (e.g. with the current date), or be left blank?

@matthewbirtch
Copy link

@matthewbirtch When the "create event" modal is opened, what value should be shown in the "end time" date selector initially? Should be filled (e.g. with the current date), or be left blank?

@mickmister the default end time should be 30 minutes from the default start time.

@wiggin77
Copy link
Member

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

@wiggin77 We are working on this. Only the QA review is left here.

@fmartingr
Copy link
Contributor

@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise.

@wiggin77 We are working on this. Only the QA review is left here.

Can you provide an estimate on when QA is going to be completed/take place?

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the conditions stated in the description. The event got created easily and there were no issues in the setting the time for the event. This looks good to me, Approved.

@Kshitij-Katiyar Kshitij-Katiyar merged commit 0949ed5 into master Jun 14, 2024
4 checks passed
@Kshitij-Katiyar Kshitij-Katiyar deleted the MM-73 branch June 14, 2024 12:12
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start time must be set but it's set automatically when using create event
6 participants