-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-73]: Fixed the issue of getting invalid start/end time even though they were set #79
Conversation
Alternatively we could have the initial/default value be given by the parent component. If the UX flow for the empty value seems fine then we can keep that solution Edit: I didn't mean to close the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a good enough compromise. 👍
@matthewbirtch When the "create event" modal is opened, what value should be shown in the "end time" date selector initially? Should be filled (e.g. with the current date), or be left blank? |
@mickmister the default end time should be 30 minutes from the default start time. |
@Kshitij-Katiyar @fmartingr customer is asking for an update on when this fix will be delivered. Please advise. |
@wiggin77 We are working on this. Only the QA review is left here. |
Can you provide an estimate on when QA is going to be completed/take place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been tested for the conditions stated in the description. The event got created easily and there were no issues in the setting the time for the event. This looks good to me, Approved.
Summary
The start/end time was auto-selected when we opened the modal to create an event but still got the error that they were invalid. So fixed it by removing the autoselected value.
Ticket Link
Fixes #73
Ticket Link