Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a popup notification when someone calls you #125

Closed
CP-Vub opened this issue Jun 22, 2022 · 40 comments · Fixed by #445
Closed

Add a popup notification when someone calls you #125

CP-Vub opened this issue Jun 22, 2022 · 40 comments · Fixed by #445
Assignees
@streamer45
Labels
enhancement New feature or request

Comments

@CP-Vub
Copy link

CP-Vub commented Jun 22, 2022

Currently, in the new calls (beta) in v7.0, when someone calls you, you get the same notification as you would get with a normal chat message. This does not really grab the attention of the receiver, who might think it's just a chat message notification or just miss it entirely due to the brevity of the notification, leaving the caller waiting indefinitely in an empty call.

Could an option be added to enable e.g. a popup window or a continuously ringing sound when someone calls you? This would greatly improve the usability of the call functionality. Currently, I am often still resorting back to MS Teams or skype in order to reach a colleague since they missed the call notification in mattermost.
@streamer45 streamer45 added the enhancement New feature or request label Jun 23, 2022
@streamer45
Copy link
Collaborator

Thanks @CP-Vub for the great feedback.

We had this kind of functionality mentioned before internally and have considered adding a "ringing" feature for calls in direct message channels. Wondering if that would cover your needs or would you expect something to work across all channel types instead?

/cc @itao

@CP-Vub
Copy link
Author

CP-Vub commented Jun 23, 2022

Thanks @streamer45 for the quick and positive reply!

Adding a ringing feature for calls in direct message channels would definitely already solve like 95% of all my personal use-case scenario's. For group channels, a call typically needs to be anyway communicated well in advance in order to align the agenda's and availability of the group members so it's way less common that I want to call an entire group channel without notice. I'm not saying it wouldn't be handy to have in group channels as well but priority-wise it's lower on the ladder for me personally.

@streamer45 streamer45 mentioned this issue Jul 11, 2022
Open
@Madscientiste
Copy link

Hello, i agree with @CP-Vub

Adding a ringing sound when someone calls you would just fix the issue for us, currently the default notification sound for when someone is calling is confusing ..

i wouldn't mind digging into the plugin and doing a PR.

@streamer45
Copy link
Collaborator

Thanks @Madscientiste , would definitely love a contribution. Let me just bring this up with the team before we commit to any work. I'll share an update here.

@Madscientiste
Copy link

@streamer45 thanks for the quick reply !

just incase, i might need help in the beginning if thats possible .. i'm not very familiar with the source

@streamer45
Copy link
Collaborator

Of course. We'd be more than happy to support you through the whole process :)

@streamer45
Copy link
Collaborator

We discussed this today and agreed it makes sense to have an additional notification mechanism for calls in DM channels. Have created a ticket to keep track of this at https://mattermost.atlassian.net/browse/MM-46823.

As soon as we have a UX proposal we can proceed with an implementation. Will give an update when that happens.

@streamer45 streamer45 self-assigned this Aug 31, 2022
@streamer45 streamer45 mentioned this issue Sep 7, 2022
Closed
@francislavoie
Copy link

Just want to give my 2 cents: I'd prefer if the "ringing" only happens in 1 on 1 calls only, and not on group chats. We've been using calls in channels sometimes when we need like 3 people in a call, but not all ~15+ people in the channel. It would be unfortunate if everyone in the channel was ringed when we open a call for that purpose. We can @ anyone who needs to be in the call in the channel at the same time and that's typically enough for us.

@streamer45
Copy link
Collaborator

Absolutely, at this point we are only planning to add this functionality to DMs (1-1s). To extend it to other channels we'd have to decouple a bit the call object such as, for example, only people invited to a call (e.g. through calendar integrations and such) would get the ping. But that's quite far ahead in the future at the moment.

@Madscientiste
Copy link

Just being curious,
Is there is any news regarding this request ? 🤔

@streamer45
Copy link
Collaborator

We are looking to tackle this functionality in the coming year.

@smarteertech
Copy link

Any updates? As a small team working remotely, we really need this to come out of Microsoft teams (Its no longer free).

@streamer45
Copy link
Collaborator

Any updates? As a small team working remotely, we really need this to come out of Microsoft teams (Its no longer free).

We are currently planning a more traditional "ringing" feature for calls in DMs which hopfeully should be ready in the next couple of months.

@benschhold
Copy link

cant wait for this, i miss all the calls

@streamer45
Copy link
Collaborator

Leaving a quick update as I know quite a few people have been waiting on this. We just started working on UX design for this functionality and planning to work on an implementation in the upcoming weeks. Hopefully the next update will be the final one :)

@Madscientiste
Copy link

Very cool !

@kaksikanaa
Copy link

kaksikanaa commented Apr 17, 2023 •
edited
Loading

Hello, any news about this feature and when it will be available?
And have I understood correctly that the notification feature includes both, a ringing tone + popup window?

@streamer45
Copy link
Collaborator

@kaksikanaa We are currently finalizing UX designs so I don't have a date for you. The plan so far is to have ringing tone (configurable) plus a notification widget come up.

@kaksikanaa
Copy link

Hello @streamer45 !
This is truly awesome. Mattermost is just fantastic tool and this feature would make the Call plugin actually useful for remote workers and teams. Have you made any progress with the implementation? We are now testing the Call plugin in our organization and this is something we still need quite desperately before we could implement it fully.

@streamer45
Copy link
Collaborator

@kaksikanaa Thanks for your trust. Designs for this are done, we are planning to begin implementing next week. We are looking at next month to ship this functionality.

@streamer45 streamer45 mentioned this issue May 10, 2023
Closed
@kaksikanaa
Copy link

Hello @streamer45, just checking (before our holiday season starts at the end of this month) -> does it look like the new feature will be available already this month? No worries if not, just checking the estimated schedule for our own planning.

@streamer45
Copy link
Collaborator

@kaksikanaa The earliest it can be in would be with 8.0 Mattermost release which is scheduled for July.

@streamer45 streamer45 mentioned this issue Jun 9, 2023
Merged
33 tasks
@myezcare-dev
Copy link

That would be awesome. This is the only thing holding us up to get rid of teams

@streamer45
Copy link
Collaborator

We are finally releasing this functionality (thanks @cpoile for the incredible contribution!).

Please keep in mind it's an experimental feature which needs to be explicitly turned on from the plugin settings.

image

Also note that it comes with some limitations which will be addressed in the next version (e.g. mobile support).

Feel free to report any issues or leave feedback. Thank you all for your patience!

@CP-Vub
Copy link
Author

CP-Vub commented Jul 8, 2023 via email

@CP-Vub
Copy link
Author

CP-Vub commented Jul 8, 2023 via email

@myezcare-dev
Copy link

myezcare-dev commented Jul 9, 2023 via email

@ageekhere
Copy link

Was mobile support (android, IOS) added yet?
Does a new issue/feature need to be created in https://github.com/mattermost/mattermost-mobile/issues or is it already being tracked?

@streamer45
Copy link
Collaborator

@ageekhere This functionality has been implemented for a while now. It needs explicit enabling though (see #125 (comment)).

Make sure to have the latest Calls plugin and Mobile version running.

@ageekhere
Copy link

@streamer45 I have that option enabled with mattermost version 9.3.0 with the latest mobile versions for both android and IOS. The ringing works on desktop however I do not get the ringing on the mobile device its self. Was the ringing only for desktop and mobile devices just get an alert or should the mobile devices also be able to get the rings?

@streamer45
Copy link
Collaborator

@cpoile Could you confirm the above?

@cpoile
Copy link
Member

cpoile commented Jan 10, 2024

@ageekhere You are correct that there isn't a ringing sound on mobile (by design). When the app is in the background or closed, the notification feature on mobile adds a custom push notification: username is inviting you to a call. When the app is open, you are given a notification banner similar to the desktop. Hope that answers the question?

@ageekhere
Copy link

@cpoile Is it possible to also have an open to enable ringing on mobile devices as well?

@cpoile
Copy link
Member

cpoile commented Jan 10, 2024

@ageekhere It's not on our roadmap at the moment but it's always possible to add it if there's enough demand.

@ageekhere
Copy link

@cpoile Well i will say that having the ringing on mobile devices would be a very cool feature to have. It is hard to find apps that allow you to ring other mobile devices while using your own servers.

@smarteertech
Copy link

We need this as well. If someone not in their computer they would miss the notification.

@cpoile
Copy link
Member

cpoile commented Jan 11, 2024 •
edited
Loading

@smarteertech They will still get a push notification on their phone (or an in-app banner if they're using the app). They just won't hear a ringing noise from their phone.

@ageekhere
Copy link

Here is the current uservoice for mobile ringing/notification ,
https://mattermost.uservoice.com/forums/306457-general/suggestions/45341932-add-a-popup-notification-when-someone-calls-you-u

The suggestion includes both a popup window notification (which was added) and a ringing sound when someone calls you"

@kaksikanaa kaksikanaa mentioned this issue Jan 17, 2024
Open
@ageekhere
Copy link

Has there been any changes to the roadmap for ringing on mobile devices?
Should i create a new Feature request issue for mobile ringing or is this already on the radar?

@streamer45
Copy link
Collaborator

@ageekhere In-app ringing is being added in mattermost/mattermost-mobile#7984, which should be available in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamer45 streamer45

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MM-52857 - DM/GM ringing mattermost/mattermost-plugin-calls
10 participants
@cpoile @streamer45 @francislavoie @benschhold @Madscientiste @ageekhere @kaksikanaa @CP-Vub @smarteertech @myezcare-dev