Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map error code for scheduled post #8628

Open
wants to merge 6 commits into
base: swipeable-delete-scheduled-post
Choose a base branch
from
Open

Map error code for scheduled post #8628

wants to merge 6 commits into from

Conversation

Rajat-Dabade
Copy link
Contributor

Summary

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

@Rajat-Dabade Rajat-Dabade marked this pull request as ready for review February 24, 2025 08:30
@Rajat-Dabade Rajat-Dabade self-assigned this Feb 24, 2025
@Rajat-Dabade Rajat-Dabade added the 2: Dev Review Requires review by a core commiter label Feb 24, 2025
@Rajat-Dabade Rajat-Dabade force-pushed the swipeable-delete-scheduled-post branch from 736f6f9 to d1c04a9 Compare February 24, 2025 18:54
@Rajat-Dabade Rajat-Dabade force-pushed the scheduled_post_error_map branch from a9f5510 to 5c8d1f5 Compare February 24, 2025 19:02
@Rajat-Dabade Rajat-Dabade added the Build Apps for PR Build the mobile app for iOS and Android to test label Feb 24, 2025
enahum
enahum approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment related to types.

Also, in case of error, how does the schedule post gets removed? Maybe a screen recording would help to see

app/components/draft_scheduled_post_header/draft_scheduled_post_header.tsx
@@ -183,7 +184,7 @@ const DraftAndScheduledPostHeader: React.FC<Props> = ({
size={12}
color={theme.buttonColor}
/>
<Text style={style.errorText}>{'CHANNEL IS READ-ONLY'}</Text>
<Text style={style.errorText}>{getErrorStringFromCode(intl, scheduledPostErrorCode as ScheduledPostErrorCode)}</Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the prop have the right type already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of an error, it will look like this:

Screenshot 2025-02-25 at 4 35 03 PM

The scheduled post should be manually deleted using scheduled post actions.

Screenshot 2025-02-25 at 4 35 54 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix the type issue in the separate PR. Create a jira ticket for it: https://mattermost.atlassian.net/browse/MM-63257

@Rajat-Dabade Rajat-Dabade force-pushed the swipeable-delete-scheduled-post branch from d1c04a9 to a6e995f Compare February 25, 2025 12:28
@Rajat-Dabade Rajat-Dabade force-pushed the scheduled_post_error_map branch from c33336d to d6f6e0e Compare February 25, 2025 12:36
@Rajat-Dabade Rajat-Dabade force-pushed the swipeable-delete-scheduled-post branch 2 times, most recently from fb548cb to eb0e95b Compare February 26, 2025 05:02
@Rajat-Dabade Rajat-Dabade force-pushed the scheduled_post_error_map branch from d6f6e0e to 2b60d2c Compare February 26, 2025 05:04
@Rajat-Dabade Rajat-Dabade added Build Apps for PR Build the mobile app for iOS and Android to test and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Feb 26, 2025
@asaadmahmood
Copy link

Looks good overall, noticed a few issues:
IMG_0747
IMG_0751
IMG_0748

Also the scheduled bar does not appear after scheduling a message.
https://github.com/user-attachments/assets/3b27f160-1c57-498f-be5c-aeb951261d20

@harshilsharma63
Copy link
Member

@asaadmahmood

  1. Done.
  2. Updated text from "Delete draft" to just "Delete". We haven't implemented the swipe to delete functionality so thats why its not expanding. We'll have to implement it at a later time.
  3. We decided to remove the part about displaying scheduled post's date and time if only one scheduled post exists as it was causing some lengthy issues. When we remove that time, the alignment and font size issues resolve automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@enahum enahum enahum approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

Assignees

@Rajat-Dabade Rajat-Dabade

Labels
2: Dev Review Requires review by a core commiter Build Apps for PR Build the mobile app for iOS and Android to test release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rajat-Dabade @asaadmahmood @harshilsharma63 @larkox @enahum @mm-cloud-bot