Swipable delete for Schedule post #8627
Open
+179
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
approved these changes
Feb 24, 2025
|
Changes look fine. Needs tests. |
736f6f9 to
d1c04a9
Compare
enahum
approved these changes
Feb 24, 2025
92506d1 to
1bdb012
Compare
d1c04a9 to
a6e995f
Compare
larkox
approved these changes
Feb 25, 2025
| defaultMessage={'Delete draft'} | ||
| style={styles1.deleteText} | ||
| /> | ||
| {draftType === DRAFT_TYPE_DRAFT ? ( |
There was a problem hiding this comment.
Missing tests for this new behavior?
1bdb012 to
39e11d0
Compare
a6e995f to
fb548cb
Compare
fb548cb to
eb0e95b
Compare
larkox
reviewed
Feb 26, 2025
Comment on lines
+103
to
+105
| DeviceEventEmitter.emit(Events.DRAFT_SWIPEABLE, mockDraft.id); | ||
|
|
||
| expect(emitSpy).toHaveBeenCalledWith(Events.DRAFT_SWIPEABLE, 'draft-id-1'); |
There was a problem hiding this comment.
This is only testing that you are calling the function that you did call in the test. This is testing nothing.
| @@ -90,4 +90,3 @@ const ScheduledPostTooltip = ({onClose}: Props) => { | |||
| }; | |||
|
|
|||
| export default ScheduledPostTooltip; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Checklist
E2E iOS tests for PR.Device Information
This PR was tested on:
Screenshots
Release Note