-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MM-62375): OutOfMemoryError issue with better catching #8622
Conversation
1373864
to
ec00bc1
Compare
@enzowritescode this APNG4Android package is now consumed as a regular npm package. Is there a way to run snyk to see if it will flag as security vulnerability? I want to be 1 step ahead. Previously, APNG4Android is added after npm install. That works, but is causing some issues among developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR addresses an OutOfMemoryError issue by improving error catching. The changes involve removing the Git clone step for the APNG4Android repository in the GitHub Actions workflow, indicating a shift in dependency management.
Reviewed Changes
File | Description |
---|---|
.github/actions/prepare-node-deps/action.yaml | Removed the cloning step for APNG4Android to streamline dependency handling |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/actions/prepare-node-deps/action.yaml:52
- The removal of the 'ci/clone-APNG4Android' step should be reviewed to ensure that the workflow does not rely on this dependency clone, potentially leading to unexpected issues in the build process.
- - name: ci/clone-APNG4Android
@enzowritescode I see "security/snyk - 14 security tests have passed", I'm assuming we're actively checking for security vulnerability. I think I should be good here. |
Also address issue brought by devs: #8625 |
Tested by @enzowritescode |
Summary
On minSdkVersion change to 21
Ticket Link
https://mattermost.atlassian.net/browse/MM-62375
Related PRs:
mattermost/APNG4Android#4
mattermost/APNG4Android#3
Checklist
E2E iOS tests for PR
.Device Information
This PR was tested on:
Screenshots
Release Note