Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump package-lock.json version to 2.26 #8617

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Bump package-lock.json version to 2.26 #8617

merged 1 commit into from
Feb 21, 2025

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Feb 19, 2025

Summary

When we bump versions, all the needed files get their version updated but the package lock. This should be automated, but in the meanwhile we do it manually.

Ticket Link

NONE

Release Note

NONE

@larkox larkox added the 2: Dev Review Requires review by a core commiter label Feb 19, 2025
@larkox larkox requested review from a team and agnivade and removed request for a team February 19, 2025 15:55
@larkox larkox requested a review from rahimrahman February 19, 2025 15:55
Copy link
Contributor

@rahimrahman rahimrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an impact if we continue to not update this?

@larkox
Copy link
Contributor Author

larkox commented Feb 19, 2025

Is there an impact if we continue to not update this?

Just developer experience, AFAIK. I don't like every time I run npm install to have an unrelated diff in my repo XD

@larkox larkox merged commit 99fa059 into main Feb 21, 2025
32 checks passed
@larkox larkox deleted the bumpPackageLock2.26 branch February 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants