List of Scheduled post in Scheduled post tab #8602

Rajat-Dabade · 2025-02-18T11:02:07Z

Summary

Ticket Link

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.
Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

Note: Please do the code review, I am parallelly adding unit tests.

Rajat-Dabade · 2025-02-21T09:24:47Z

app/screens/global_drafts/components/draft_and_scheduled_post_swipe_actions.tsx

-    const deleteDraft = useCallback(() => {
+    const deletePost = useCallback(() => {
+        if (draftType === DRAFT_TYPE_SCHEDULED) {
+            // TODO: Add swipeable delete for schedule post


This will be handled in the subsequent PR. https://mattermost.atlassian.net/browse/MM-62200

Rajat-Dabade · 2025-02-21T09:25:19Z

app/screens/global_drafts/components/global_scheduled_post_list/global_scheduled_post_list.tsx

+                maxToRenderPerBatch={10}
+                nativeID={location}
+                renderItem={renderItem}
+                ListEmptyComponent={DraftEmptyComponent} //TODO: Change this to ScheduledPostEmptyComponent


Will handle this in subsequent PR. https://mattermost.atlassian.net/browse/MM-63142

enahum

Some questions non-blocking

app/components/draft_scheduled_post_header/profile_avatar.tsx

enahum · 2025-02-21T09:55:39Z

app/screens/global_drafts/components/tabbed_contents/tabbed_contents.tsx

@@ -34,7 +34,7 @@ const getStyleSheet = (width: number) => {
            width,
        },
        hiddenTabContent: {
-            display: 'none',
+            opacity: 0,


Why this change?

I recall an issue with rendering the Scheduled Post list in the tab for the first time. Since @harshilsharma63 owns this code, he might have more context on it.

This is because the way we have tabs, we shift the tab contents left or right when navigating to a different tab. If you go from Tab A to Tab B, and you hide tab A by display: none, now it no longer takes any width and the Tab B immediately and abrubtly shows up in the screen and there is no way to smoothen it. But, if you set opacity 0 of tab A, it still occupies the width and you can smoothly transition tab B into screen. This is how all tabs work. I had set display none mistakenly earlier and this corrects it.

larkox

Please take a look to the date formatting issues. The rest is not so important from my side, but nice to haves.

app/utils/datetime.ts

app/utils/datetime.test.ts

app/screens/global_drafts/draft_scheduled_post_tooltip.tsx

app/screens/global_drafts/components/global_scheduled_post_list/global_scheduled_post_list.tsx

app/screens/global_drafts/components/global_scheduled_post_list/index.tsx

app/screens/global_drafts/components/draft_and_scheduled_post_swipe_actions.tsx

app/queries/servers/scheduled_post.ts

app/components/draft_scheduled_post_header/draft_scheduled_post_header.tsx

app/components/draft_scheduled_post/draft_scheduled_post.tsx

larkox

I am going to pre-approve, but please extract to constants the size of the tooltip.

larkox · 2025-02-26T12:32:52Z

app/screens/global_drafts/constants.ts

+export const DRAFT_TYPE_DRAFT = 'draft';
+export const DRAFT_TYPE_SCHEDULED = 'scheduled';


In a different PR I was commenting that if you add here as const to both constants, you will probably have to use less castings.

larkox · 2025-02-26T12:34:29Z

app/screens/global_drafts/components/global_scheduled_post_list/global_scheduled_post_list.tsx

+        tooltipContentStyle: {
+            borderRadius: 8,
+            width: 247,
+            padding: 16,
+            height: 160,
+        },


If it is constant across the platform, extract the constants to a common file, and use the constants.

I don't like it is constant (the container should accommodate the content) but I understand that is out of the scope right now.

larkox · 2025-02-26T12:35:33Z

app/screens/global_drafts/components/global_scheduled_post_list/global_scheduled_post_list.tsx

+    const [layoutWidth, setLayoutWidth] = useState(0);
+    const [tooltipVisible, setTooltipVisible] = useState(false);
+    const onLayout = useCallback((e: LayoutChangeEvent) => {
+        setLayoutWidth(e.nativeEvent.layout.width - DRAFT_SCHEDULED_POST_LAYOUT_PADDING); // 40 is the padding of the container


The comment is no longer needed, I think.

larkox · 2025-02-26T12:39:43Z

app/screens/global_drafts/components/global_drafts_list/global_drafts_list.tsx

@@ -63,7 +63,7 @@ const GlobalDraftsList: React.FC<Props> = ({
    const [tooltipVisible, setTooltipVisible] = useState(false);
    const onLayout = useCallback((e: LayoutChangeEvent) => {
        if (location === Screens.GLOBAL_DRAFTS) {
-            setLayoutWidth(e.nativeEvent.layout.width - 40); // 40 is the padding of the container
+            setLayoutWidth(e.nativeEvent.layout.width - DRAFT_SCHEDULED_POST_LAYOUT_PADDING); // 40 is the padding of the container


This comment here is no longer needed.

larkox · 2025-02-26T15:59:49Z

@Rajat-Dabade I don't see any changes since my last review. Did you miss a push?

enahum · 2025-02-26T17:55:07Z

app/screens/global_drafts/draft_scheduled_post_tooltip.test.tsx

+            />,
+        );
+
+        fireEvent.press(getByTestId('draft.tooltip.close.button'));


This should be inside an act, I think

mm-cloud-bot added the release-note label Feb 18, 2025

Rajat-Dabade force-pushed the add-create-at-column-scheduled-post branch from 6a284f4 to 68eff02 Compare February 21, 2025 07:16

Rajat-Dabade force-pushed the list-scheduled-post branch 2 times, most recently from de2b148 to 3a6f367 Compare February 21, 2025 09:15

Rajat-Dabade commented Feb 21, 2025

View reviewed changes

Rajat-Dabade requested review from harshilsharma63 and enahum February 21, 2025 09:46

Rajat-Dabade self-assigned this Feb 21, 2025

Rajat-Dabade added the 2: Dev Review Requires review by a core commiter label Feb 21, 2025

Rajat-Dabade requested a review from larkox February 21, 2025 09:47

Rajat-Dabade marked this pull request as ready for review February 21, 2025 09:47

enahum approved these changes Feb 21, 2025

View reviewed changes

harshilsharma63 approved these changes Feb 21, 2025

View reviewed changes

larkox requested changes Feb 24, 2025

View reviewed changes

Rajat-Dabade force-pushed the add-create-at-column-scheduled-post branch from 8ee12ac to 96f7359 Compare February 25, 2025 09:32

Rajat-Dabade added 7 commits February 25, 2025 15:09

updated test

adcc2cb

List of Scheduled post in Scheduled post tab

097a981

header fixes

8a63d65

added header files for scheduled post

fc18a14

Minor

cf203b1

intl fixes

1cc8256

getReadableTimeStamp uses current user locale

63d31e5

Rajat-Dabade force-pushed the list-scheduled-post branch from 68bf2da to 63d31e5 Compare February 25, 2025 09:41

Rajat-Dabade added 3 commits February 25, 2025 15:12

updated test

5fd52d6

removed at from the scheduled post header and added tests

340f74c

Addressed review comment

4d1ca88

Rajat-Dabade requested a review from larkox February 26, 2025 10:05

larkox approved these changes Feb 26, 2025

View reviewed changes

Rajat-Dabade requested a review from larkox February 26, 2025 15:57

enahum approved these changes Feb 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List of Scheduled post in Scheduled post tab #8602

List of Scheduled post in Scheduled post tab #8602

Rajat-Dabade commented Feb 18, 2025 •

edited

Loading

Rajat-Dabade Feb 21, 2025

Rajat-Dabade Feb 21, 2025 •

edited

Loading

enahum left a comment

enahum Feb 21, 2025

Rajat-Dabade Feb 21, 2025

harshilsharma63 Feb 21, 2025

larkox left a comment

larkox left a comment

larkox Feb 26, 2025

larkox Feb 26, 2025

larkox Feb 26, 2025

larkox Feb 26, 2025

larkox commented Feb 26, 2025

enahum Feb 26, 2025

		export const DRAFT_TYPE_DRAFT = 'draft';
		export const DRAFT_TYPE_SCHEDULED = 'scheduled';

List of Scheduled post in Scheduled post tab #8602

Are you sure you want to change the base?

List of Scheduled post in Scheduled post tab #8602

Conversation

Rajat-Dabade commented Feb 18, 2025 • edited Loading

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

Choose a reason for hiding this comment

Rajat-Dabade Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

enahum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larkox commented Feb 26, 2025

Choose a reason for hiding this comment

Rajat-Dabade commented Feb 18, 2025 •

edited

Loading

Rajat-Dabade Feb 21, 2025 •

edited

Loading