Added create_at column to scheduled post local table #8601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a284f4 to
68eff02
Compare
enahum
approved these changes
Feb 21, 2025
| @@ -167,7 +167,7 @@ export const transformSchedulePostsRecord = ({action, database, value}: Transfor | |||
| scheduledPost.rootId = raw?.root_id ?? ''; | |||
| scheduledPost.message = raw?.message ?? ''; | |||
| scheduledPost.channelId = raw?.channel_id ?? ''; | |||
| scheduledPost.files = raw?.files ?? emptyFileInfo; | |||
| scheduledPost.files = raw?.metadata?.files ?? emptyFileInfo; | |||
| scheduledPost.metadata = raw?.metadata ?? null; | |||
There was a problem hiding this comment.
I guess this is not part of this PR, but 0/5
harshilsharma63
approved these changes
Feb 21, 2025
larkox
approved these changes
Feb 24, 2025
| @@ -22,6 +22,7 @@ export default schemaMigrations({migrations: [ | |||
| {name: 'files', type: 'string'}, | |||
| {name: 'root_id', type: 'string', isIndexed: true}, | |||
| {name: 'metadata', type: 'string', isOptional: true}, | |||
| {name: 'create_at', type: 'number'}, | |||
There was a problem hiding this comment.
Sanity check: Here we are reusing a migration. Is that intended? I understand it is, because this will be the migration for the whole feature, and not something already in main, right?
There was a problem hiding this comment.
Yup, that's right, the whole feature needs migration (adding the scheduled post table to the local db), this is just a small part which was left.
20d7c19 to
68e9542
Compare
8ee12ac to
96f7359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Checklist
E2E iOS tests for PR.Device Information
This PR was tested on:
Screenshots
Release Note