Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.25 fixes #8578

Merged
merged 2 commits into from
Feb 11, 2025
Merged

2.25 fixes #8578

merged 2 commits into from
Feb 11, 2025

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Feb 11, 2025

Summary

Fixes push notification fetching data and replying to the notification on android
Fixes the UI when switching between tabs on the home screen

Ticket Link

https://mattermost.atlassian.net/browse/MM-62943

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone 3: QA Review Requires review by a QA tester labels Feb 11, 2025
@enahum enahum added this to the v2.25.0 milestone Feb 11, 2025
@enahum
Copy link
Contributor Author

enahum commented Feb 11, 2025

Needs cherry pick to 2.26

@enahum enahum added the Build Apps for PR Build the mobile app for iOS and Android to test label Feb 11, 2025
@enahum enahum requested a review from Willyfrog February 11, 2025 03:14
lindalumitchell
lindalumitchell approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@lindalumitchell lindalumitchell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the Android fix for replying from push notification when the app is closed and the user logged in using SSO. Also ran through some of the usual smoke tests on Android and iOS. Looks good! 🎉

@amyblais amyblais added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Feb 11, 2025
Willyfrog
Willyfrog approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, so I'm approving.
Are the changes to fix this in the network client?

@Willyfrog
Copy link
Contributor

Code looks good, so I'm approving.
Are the changes to fix this in the network client?

I'm guessing this is the fix: mattermost/react-native-network-client@68162d4

@enahum enahum merged commit 4407ca0 into main Feb 11, 2025
63 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@enahum enahum deleted the 2.25-fixes branch February 11, 2025 09:21
mattermost-build pushed a commit that referenced this pull request Feb 11, 2025
@enahum @mattermost-build
2.25 fixes (#8578)
6421484 
(cherry picked from commit 4407ca0)
@enahum enahum removed the 2: Dev Review Requires review by a core commiter label Feb 11, 2025
@mattermost-build mattermost-build mentioned this pull request Feb 11, 2025
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Feb 11, 2025
@enahum
Copy link
Contributor Author

enahum commented Feb 11, 2025

/cherry-pick release-2.26

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Feb 11, 2025
@enahum @mattermost-build
2.25 fixes (#8578)
3b96938 
(cherry picked from commit 4407ca0)
@mattermost-build mattermost-build mentioned this pull request Feb 11, 2025
Merged
enahum pushed a commit that referenced this pull request Feb 11, 2025
@mattermost-build
2.25 fixes (#8578) (#8580)
ab7f3f7
enahum pushed a commit that referenced this pull request Feb 11, 2025
@mattermost-build
2.25 fixes (#8578) (#8581)
747982a
Willyfrog pushed a commit that referenced this pull request Feb 19, 2025
@enahum @Willyfrog
2.25 fixes (#8578)
5dedf57
Rajat-Dabade pushed a commit that referenced this pull request Feb 25, 2025
@enahum @Rajat-Dabade
2.25 fixes (#8578)
13f6de1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@larkox larkox larkox approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@lindalumitchell lindalumitchell lindalumitchell approved these changes

@rahimrahman rahimrahman Awaiting requested review from rahimrahman

Assignees
No one assigned
Labels
Build Apps for PR Build the mobile app for iOS and Android to test CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone QA Review Done release-note-none
Projects
None yet
Milestone
v2.25.0
Development

Successfully merging this pull request may close these issues.
8 participants
@enahum @Willyfrog @mattermost-build @larkox @yasserfaraazkhan @lindalumitchell @amyblais @mm-cloud-bot