-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-54703] Fix IPv6 issue on android #8571
base: main
Are you sure you want to change the base?
Conversation
Hello @rossjackson, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
@rossjackson Thank you for the PR but a couple of things
@rahimrahman thoughts? |
Hi @enahum , I completely understand. The current version of okhttp doesn't have the DNS resolution which I think is causing this IPv4 and IPv6 issues, the v5 does. I added it as an override as a temporary fix until okhttp releases its v5. I was hoping this will be fine for the interim so some of your android users using data or on VPN can still use the app. |
I'm in agreement with @enahum
However, perhaps it's not a bad idea to implement this as an experimental version of the Mattermost app where we can deploy it to ourselves with an environment that has both IPv4 and IPv6, and lperhaps even at the same time, release to some of our users who are experiencing issues, and gather some data. I haven't had the chance to do any type of research, but do you know if there's any talk on when they are thinking about moving okhttp v5 out of alpha phase? |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Not all servers may have IPv4 and IPv6 enabled and when that happens Android switching from WiFi to mobile data can interchangeably switch IP addresses. Most users on Android, including me, has experienced slow connection especially when the server is running on docker. I also experienced this issue using my other react-native app and have applied this same changes and fixed the issue. This fix is from a SO post. This will resolve this issue.
Ticket Link
MM-54703
Checklist
E2E iOS tests for PR
.Device Information
Android API 35
Release Note