Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to run detox tests on Android #8553

Merged
merged 113 commits into from
Feb 13, 2025
Merged

Add ability to run detox tests on Android #8553

merged 113 commits into from
Feb 13, 2025

Conversation

yasserfaraazkhan
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan commented Feb 4, 2025 •
edited
Loading

Summary

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

NONE

@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Feb 12, 2025
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
larkox
larkox approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Yasser!

@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 12, 2025
@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 13, 2025
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Feb 13, 2025
@yasserfaraazkhan yasserfaraazkhan merged commit 9976cac into main Feb 13, 2025
31 checks passed
@yasserfaraazkhan yasserfaraazkhan deleted the combine-ios-android-e2e branch February 13, 2025 19:56
Willyfrog pushed a commit that referenced this pull request Feb 19, 2025
@yasserfaraazkhan @Willyfrog
Add ability to run detox tests on Android (#8553)
5349140
Rajat-Dabade pushed a commit that referenced this pull request Feb 25, 2025
@yasserfaraazkhan @Rajat-Dabade
Add ability to run detox tests on Android (#8553)
007fbcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@enahum enahum enahum approved these changes

@mvitale1989 mvitale1989 mvitale1989 approved these changes

@saturninoabril saturninoabril Awaiting requested review from saturninoabril

@rahimrahman rahimrahman Awaiting requested review from rahimrahman

Assignees
No one assigned
Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasserfaraazkhan @larkox @enahum @mvitale1989 @mm-cloud-bot @mattermost-build