Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Mobile CMT testing #7994

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Introduce Mobile CMT testing #7994

merged 5 commits into from
Jun 10, 2024

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Jun 7, 2024

Summary

  • Refactor e2e detox workflows for simplicity
  • Introduce mobile CMT testing

Ticket Link

https://mattermost.atlassian.net/browse/CLD-7723

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note labels Jun 7, 2024
yasserfaraazkhan
yasserfaraazkhan approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @toninis 🎉

@yasserfaraazkhan yasserfaraazkhan added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
enahum
enahum approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@toninis toninis added E2E iOS tests for PR Run iOS E2E Detox tests and removed E2E iOS tests for PR Run iOS E2E Detox tests labels Jun 7, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@toninis toninis added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 7, 2024
@toninis toninis added the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 10, 2024
@github-actions github-actions bot removed the E2E iOS tests for PR Run iOS E2E Detox tests label Jun 10, 2024
@toninis toninis merged commit 54d009d into main Jun 10, 2024
23 checks passed
@toninis toninis deleted the feat/introduce-cmt-testing branch June 10, 2024 11:06
@amyblais amyblais added this to the v2.18.0 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum approved these changes

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@saturninoabril saturninoabril Awaiting requested review from saturninoabril

@mvitale1989 mvitale1989 Awaiting requested review from mvitale1989

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@toninis @enahum @yasserfaraazkhan @amyblais @mm-cloud-bot