Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T271: Prevent access to Android components if they do not need external comms #7990

Merged
merged 1 commit into from
Jun 11, 2024
Merged

T271: Prevent access to Android components if they do not need external comms #7990

merged 1 commit into from
Jun 11, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Jun 5, 2024

Summary

This PR patches a couple of dependencies to set the activities and services with the flag of exported=false

Also address in this PR, corrections to our own Manifest file to apply exported=false and other improvements, specially around backups.

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: Security Review Review requested from Security Team labels Jun 5, 2024
@enahum enahum requested review from cpoile, larkox and esarafianou June 5, 2024 03:45
cpoile
cpoile approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elias, I tested it and everything works for Calls as it should.

@enahum enahum added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels Jun 10, 2024
@enahum enahum added this to the v2.18.0 milestone Jun 10, 2024
@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 3: Security Review Review requested from Security Team labels Jun 11, 2024
@enahum enahum merged commit daa38c5 into main Jun 11, 2024
39 checks passed
@enahum enahum deleted the android-exported branch June 11, 2024 16:45
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Jun 11, 2024
@enahum @mattermost-build
T271: Prevent access to Android components if they do not need extern…
35ba39e 
…al communication (#7990)

(cherry picked from commit daa38c5)
@mattermost-build mattermost-build mentioned this pull request Jun 11, 2024
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 11, 2024
enahum added a commit that referenced this pull request Jun 11, 2024
@mattermost-build @enahum
T271: Prevent access to Android components if they do not need extern…
1594d5e 
…al communication (#7990) (#8005)

(cherry picked from commit daa38c5)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

@larkox larkox larkox approved these changes

@esarafianou esarafianou esarafianou approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.
7 participants
@enahum @mattermost-build @cpoile @larkox @esarafianou @amyblais @mm-cloud-bot