Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate E2E testing #124

Closed
larkox opened this issue Oct 5, 2020 · 5 comments · Fixed by #228 · May be fixed by rahulsuresh-git/mattermost-plugin-todo#1
Closed

Integrate E2E testing #124

larkox opened this issue Oct 5, 2020 · 5 comments · Fixed by #228 · May be fixed by rahulsuresh-git/mattermost-plugin-todo#1
Assignees
@rahulsuresh-git
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature
Milestone
v1.0.0

Comments

@larkox
Copy link
Contributor

larkox commented Oct 5, 2020

Following a similar design as in the Incident Response Plugin integrate Cypress E2E testing for this plugin.

At least one simple test case has to be added to make sure the system works.
@larkox larkox added Help Wanted Community help wanted Difficulty/2:Medium Medium ticket Hacktoberfest Up For Grabs Ready for help from the community. Removed when someone volunteers Type/Enhancement New feature or improvement of existing feature Tech/TypeScript Tech/ReactJS and removed Tech/TypeScript labels Oct 5, 2020
@jeromegrosse
Copy link

I can give it a shot!

@larkox
Copy link
Contributor Author

larkox commented Feb 14, 2022

Thanks @jeromegrosse ! If you need anything, do not hesitate to ask!

@larkox larkox removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 14, 2022
@rahulsuresh-git
Copy link
Contributor

Is this still open? I was wondering of introducing Playwright for E2E tests as recommended here (https://developers.mattermost.com/contribute/more-info/desktop/testing/). Any thoughts? @larkox @mickmister

@mickmister
Copy link
Contributor

@rahulsuresh-git Certainly this issue is still open 👍

Using playwright sounds good to me. There are some existing tests in the GitHub plugin that can be used for inspiration https://github.com/mattermost/mattermost-plugin-github/tree/master/e2e/playwright

Thanks for your interest in contributing @rahulsuresh-git!

@rahulsuresh-git
Copy link
Contributor

Sure, thank you! I'll get at it right away.
It's good to be back at contributing to Mattermost. I'll get back to you in case of any questions :)

This was referenced Nov 1, 2023
Open
Merged
rahulsuresh-git added a commit to rahulsuresh-git/mattermost-plugin-todo that referenced this issue Nov 18, 2023
@rahulsuresh-git
[mattermost-communityGH-124]: Integrating Playwright for E2E tests (m…
65296b8 
…attermost-community#228)

* setup playwright using docs

* fixed setup commands in setup-environment script

* added readme

* added config for playwright

* integrated playwright utils and added test to check available commands

* removed changes from user.ts

* fixed TodoBot URL

* removed a comment

* improvements to message input function

* fixed issue with cleanUpBotDMs

* added github workflow for playwright

* updated workflow with workflow_dispatch

* updated node version in .nvmrc

* updated package-lock.json

* updated package-lock.json for node 16.13.1

* updated package-lock.json for node 16.13.1

* added python to workflow

* removed python from workflow and removed package-lock.json cache

* attempts to fix workflow failure

* attempts to fix workflow failure

* attempts to fix workflow failure

* reverted workflow changes

* reverted workflow changes

* disabled caching in workflow

* updated to node 18.17 and updated setup-environment

* updated workflow with new steps

* changed checkout method for mattermost-monorepo

* fixed tsc errors

* commented out playwright ci/lint in workflow

* updated workflow to run on pull_request

* updated workflow triggers
@avas27JTG avas27JTG added this to the v1.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulsuresh-git rahulsuresh-git

Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
v1.0.0
6 participants
@larkox @cpanato @jeromegrosse @mickmister @rahulsuresh-git @avas27JTG