Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(en): better defaults, i.e. the same as used by main node #3521

Merged
merged 7 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/bin/external_node/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -772,15 +772,15 @@ impl OptionalENConfig {
}

const fn default_estimate_gas_scale_factor() -> f64 {
1.2
1.3
}

const fn default_estimate_gas_acceptable_overestimation() -> u32 {
1_000
5_000
}

const fn default_gas_price_scale_factor() -> f64 {
1.2
1.5
}

const fn default_max_nonce_ahead() -> u32 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ EN_PUBSUB_POLLING_INTERVAL=200
EN_MAX_NONCE_AHEAD=50
# The multiplier to use when suggesting gas price. Should be higher than one,
# otherwise if the L1 prices soar, the suggested gas price won't be sufficient to be included in block.
EN_GAS_PRICE_SCALE_FACTOR=1.2
EN_GAS_PRICE_SCALE_FACTOR=1.5
# The factor by which to scale the gasLimit
EN_ESTIMATE_GAS_SCALE_FACTOR=1.2
EN_ESTIMATE_GAS_SCALE_FACTOR=1.3
# The max possible number of gas that `eth_estimateGas` is allowed to overestimate.
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=1000
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=5000
# Max possible size of an ABI encoded tx (in bytes).
# This shouldn't be larger than the value on the main node.
EN_MAX_TX_SIZE=1000000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ EN_PUBSUB_POLLING_INTERVAL=200
EN_MAX_NONCE_AHEAD=50
# The multiplier to use when suggesting gas price. Should be higher than one,
# otherwise if the L1 prices soar, the suggested gas price won't be sufficient to be included in block.
EN_GAS_PRICE_SCALE_FACTOR=1.2
EN_GAS_PRICE_SCALE_FACTOR=1.5
# The factor by which to scale the gasLimit
EN_ESTIMATE_GAS_SCALE_FACTOR=1.2
EN_ESTIMATE_GAS_SCALE_FACTOR=1.3
# The max possible number of gas that `eth_estimateGas` is allowed to overestimate.
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=1000
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=5000
# Max possible size of an ABI encoded tx (in bytes).
# This shouldn't be larger than the value on the main node.
EN_MAX_TX_SIZE=1000000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ EN_PUBSUB_POLLING_INTERVAL=200
EN_MAX_NONCE_AHEAD=50
# The multiplier to use when suggesting gas price. Should be higher than one,
# otherwise if the L1 prices soar, the suggested gas price won't be sufficient to be included in block.
EN_GAS_PRICE_SCALE_FACTOR=1.2
EN_GAS_PRICE_SCALE_FACTOR=1.5
# The factor by which to scale the gasLimit
EN_ESTIMATE_GAS_SCALE_FACTOR=1.2
EN_ESTIMATE_GAS_SCALE_FACTOR=1.3
# The max possible number of gas that `eth_estimateGas` is allowed to overestimate.
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=1000
EN_ESTIMATE_GAS_ACCEPTABLE_OVERESTIMATION=5000
# Max possible size of an ABI encoded tx (in bytes).
# This shouldn't be larger than the value on the main node.
EN_MAX_TX_SIZE=1000000
Expand Down
Loading