Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Compressor optimizations #3476

Merged
merged 27 commits into from
Jan 23, 2025
Merged

feat: Compressor optimizations #3476

merged 27 commits into from
Jan 23, 2025

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Jan 15, 2025 •
edited
Loading

What ❔

Integrate optimizations for compressor's work.
Before:
PLONK: ~180s
FFLONK: ~248s
Now
Both: ~70s

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@Artemka374 Artemka374 requested a review from a team as a code owner January 15, 2025 14:36
Unsainted374 and others added 17 commits January 15, 2025 15:46
zksync-admin-bot2 and others added 2 commits January 17, 2025 14:08
@zksync-admin-bot2 @Artemka374
chore: Update generated Prover FRI GPU setup-data keys from branch af…
e59c354 
…o/faster-compressor (#3496)

"Update generated Prover FRI GPU setup-data keys from branch
afo/faster-compressor"

---------

Co-authored-by: Lech <88630083+Artemka374@users.noreply.github.com>
@Artemka374
bump dependencies
07b9310
EmilLuta
EmilLuta reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but given we're changing all the keys, isn't this a "protocol upgrade"?

zkstack_cli/crates/zkstack/src/commands/prover/args/compressor_keys.rs Show resolved Hide resolved
.gitignore Show resolved Hide resolved
core/Cargo.toml Show resolved Hide resolved
@Artemka374
Copy link
Contributor Author

Regarding the protocol upgrade - no, the keys are actually not changed, the only thing changed there is the format of them

@EmilLuta EmilLuta changed the title feat: Compressor optimizations feat!: Compressor optimizations Jan 23, 2025
@EmilLuta
Copy link
Contributor

Note: CRS & Keys are being changed, therefore we mark this PR as breaking.

EmilLuta
EmilLuta previously approved these changes Jan 23, 2025
View reviewed changes
@Artemka374 Artemka374 changed the title feat!: Compressor optimizations feat: Compressor optimizations Jan 23, 2025
@Artemka374 Artemka374 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 3e931be Jan 23, 2025
43 checks passed
@Artemka374 Artemka374 deleted the afo/faster-compressor branch January 23, 2025 16:08
This was referenced Jan 23, 2025
Merged
Closed
Open
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
@zksync-era-bot @antonbaliasnikov
chore(main): release core 26.2.0 (#3528)
fc06147 
🤖 I have created a release *beep* *boop*
---


##
[26.2.0](core-v26.1.0...core-v26.2.0)
(2025-01-24)


### Features

* Compressor optimizations
([#3476](#3476))
([3e931be](3e931be))


### Bug Fixes

* **en:** better defaults, i.e. the same as used by main node
([#3521](#3521))
([2b5fe98](2b5fe98))
* **en:** Fix race condition in EN storage initialization
([#3515](#3515))
([c916797](c916797))
* JSON proof serialization
([#3514](#3514))
([516e521](516e521))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Co-authored-by: Anton Baliasnikov <aba@matterlabs.dev>
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2025
@zksync-era-bot
chore(main): release prover 18.0.0 (#3338)
32a068d 
🤖 I have created a release *beep* *boop*
---


##
[18.0.0](prover-v17.1.1...prover-v18.0.0)
(2025-01-27)


### ⚠ BREAKING CHANGES

* **contracts:** gateway integration
([#1934](#1934))

### Features

* Compressor optimizations
([#3476](#3476))
([3e931be](3e931be))
* **consensus:** Added view_timeout to consensus config
([#3383](#3383))
([fc02a8f](fc02a8f))
* **consensus:** Update consensus dependencies
([#3339](#3339))
([aa9575f](aa9575f))
* **contracts:** gateway integration
([#1934](#1934))
([f06cb79](f06cb79))
* **eth-watch:** Change protocol upgrade schema
([#3435](#3435))
([2c778fd](2c778fd))
* FFLONK support for compressor
([#3359](#3359))
([1a297be](1a297be))
* Support stable compiler for VM (and some other crates)
([#3248](#3248))
([cbee99d](cbee99d))


### Bug Fixes

* added missing quote in prover query
([#3347](#3347))
([668ca51](668ca51))
* Compressor setup data
([#3526](#3526))
([62aea8b](62aea8b))
* **prover:** Create reqwest client only once
([#3324](#3324))
([40f8123](40f8123))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwaa iluwaa iluwaa approved these changes

@EmilLuta EmilLuta EmilLuta left review comments

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Artemka374 @EmilLuta @iluwaa @Unsainted374 @zksync-admin-bot2